next-20160607 build: 2 failures 9 warnings (next-20160607)

next-20160607 build: 2 failures 9 warnings (next-20160607)

[Mark Brown]

On Tue, Jun 07, 2016 at 08:35:02AM +0100, Build bot for Mark Brown wrote:

Today's -next fails to build an arm64 allmodconfig due to:

> 	arm64-allmodconfig
> ../drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h:19:27: fatal error: asm/dma-iommu.h: No such file or directory

introduced by 04f776734c4e (media: s5p-mfc: add iommu support) which
relies on a header which is only available on 32 bit ARM.  I suspect the
driver should be using linux/dma-iommu.h instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160607/eae13f6d/attachment.sig>

[PATCH] media: s5p-mfc: fix compilation issue on archs other than ARM (32bit)

[Marek Szyprowski]

This patch fixes build break caused by lack of dma-iommu API on ARM64
(this API is specific to ARM 32bit architecture).

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h b/drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h
index 5d1d1c2..6962132 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h
@@ -14,7 +14,7 @@
 #define S5P_MFC_IOMMU_DMA_BASE	0x20000000lu
 #define S5P_MFC_IOMMU_DMA_SIZE	SZ_256M
 
-#ifdef CONFIG_EXYNOS_IOMMU
+#if defined(CONFIG_EXYNOS_IOMMU) && defined(CONFIG_ARM_DMA_USE_IOMMU)
 
 #include <asm/dma-iommu.h>
 
-- 
1.9.2

next-20160607 build: 2 failures 9 warnings (next-20160607)

[Sylwester Nawrocki]

On 06/07/2016 12:58 PM, Mark Brown wrote:
> On Tue, Jun 07, 2016 at 08:35:02AM +0100, Build bot for Mark Brown wrote:
> 
> Today's -next fails to build an arm64 allmodconfig due to:
> 
>> 	arm64-allmodconfig
>> ../drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h:19:27: fatal error: asm/dma-iommu.h: No such file or directory
> 
> introduced by 04f776734c4e (media: s5p-mfc: add iommu support) which
> relies on a header which is only available on 32 bit ARM.  I suspect the
> driver should be using linux/dma-iommu.h instead.

Since the mfc topic branch got already pulled to the samsung-soc tree,
as discussed in other thread [1], there is a build break in -next.
There is a patch to fix this issue and to include it in next, as we
agreed  on irc, could you please pull this branch into your "for-next"
tree:

git://linuxtv.org/snawrocki/samsung.git for-v4.8/media/exynos-mfc

and then apply that patch [2] ?
"media: s5p-mfc: fix compilation issue on archs other than ARM (32bit)"

-- 
Thanks,
Sylwester

[1] https://patchwork.linuxtv.org/patch/34495
[2] https://patchwork.linuxtv.org/patch/34515

next-20160607 build: 2 failures 9 warnings (next-20160607)

[Mauro Carvalho Chehab]

Em Tue, 07 Jun 2016 15:22:58 +0200
Sylwester Nawrocki <s.nawrocki@samsung.com> escreveu:

> On 06/07/2016 12:58 PM, Mark Brown wrote:
> > On Tue, Jun 07, 2016 at 08:35:02AM +0100, Build bot for Mark Brown wrote:
> > 
> > Today's -next fails to build an arm64 allmodconfig due to:
> >   
> >> 	arm64-allmodconfig
> >> ../drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h:19:27: fatal error: asm/dma-iommu.h: No such file or directory  
> > 
> > introduced by 04f776734c4e (media: s5p-mfc: add iommu support) which
> > relies on a header which is only available on 32 bit ARM.  I suspect the
> > driver should be using linux/dma-iommu.h instead.  
> 
> Since the mfc topic branch got already pulled to the samsung-soc tree,
> as discussed in other thread [1], there is a build break in -next.
> There is a patch to fix this issue and to include it in next, as we
> agreed  on irc, could you please pull this branch into your "for-next"
> tree:
> 
> git://linuxtv.org/snawrocki/samsung.git for-v4.8/media/exynos-mfc
> 
> and then apply that patch [2] ?
> "media: s5p-mfc: fix compilation issue on archs other than ARM (32bit)"

Sure. Applied, thanks!

Mauro