From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: serial: msm: fix definition of msm_stop_dma
Date: Tue, 7 Jun 2016 13:00:41 -0700 [thread overview]
Message-ID: <20160607200041.GJ1256@tuxbot> (raw)
In-Reply-To: <1465323112-32366-1-git-send-email-ben.dooks@codethink.co.uk>
On Tue 07 Jun 11:11 PDT 2016, Ben Dooks wrote:
> The msm_stop_dma() is not exported from the driver, so make
> it static to stop the following warning:
>
> drivers/tty/serial/msm_serial.c:84:6: warning: symbol 'msm_stop_dma' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-arm-msm at vger.kernel.org
> Cc: linux-soc at vger.kernel.org
> Cc: linux-serial at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/tty/serial/msm_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index b7d80bd..187f2c0 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -81,7 +81,7 @@ struct msm_port {
> static void msm_handle_tx(struct uart_port *port);
> static void msm_start_rx_dma(struct msm_port *msm_port);
>
> -void msm_stop_dma(struct uart_port *port, struct msm_dma *dma)
> +static void msm_stop_dma(struct uart_port *port, struct msm_dma *dma)
> {
> struct device *dev = port->dev;
> unsigned int mapped;
> --
> 2.8.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-06-07 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:11 [PATCH] tty: serial: msm: fix definition of msm_stop_dma Ben Dooks
2016-06-07 20:00 ` Bjorn Andersson [this message]
2016-06-07 23:07 ` Stephen Boyd
2016-06-09 19:21 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607200041.GJ1256@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).