public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led
Date: Tue, 7 Jun 2016 23:24:19 +0200	[thread overview]
Message-ID: <20160607212419.GE14179@lukather> (raw)
In-Reply-To: <1465129393-22379-1-git-send-email-hdegoede@redhat.com>

On Sun, Jun 05, 2016 at 02:23:11PM +0200, Hans de Goede wrote:
> The blue led on the Mele A1000 is wired to light up as soon as the board
> has powered (it will be on while the gpio is still in input / floating
> mode), also its location on the top-set box clearly signals "power led".
> 
> Until now we've been treating this as a generic usr function led, which
> means that when you plug power into the top-set box, the power-led lights
> and then turns off as soon as the kernel loads, which looks wrong.

I'm not sure I understand the relationship between usr vs pwr led and
the fact that it's disabled.

> This renames the led from a1000:blue:usr to a1000:blue:pwr and marks
> it as default on, fixing this.

however, the default on might. Is it just a confusing commit log, or
am I overlooking something?

thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160607/a71af183/attachment-0001.sig>

  parent reply	other threads:[~2016-06-07 21:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-05 12:23 [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led Hans de Goede
2016-06-05 12:23 ` [PATCH 2/3] ARM: dts: sun6i: The blue led on the Mele A1000G quad " Hans de Goede
2016-06-06  7:01   ` Chen-Yu Tsai
2016-06-05 12:23 ` [PATCH 3/3] ARM: dts: sun6i: The blue led on the Mele M9 " Hans de Goede
2016-06-06  7:02   ` Chen-Yu Tsai
2016-06-06  7:01 ` [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 " Chen-Yu Tsai
2016-06-06  7:05   ` Chen-Yu Tsai
2016-06-06  7:24     ` Hans de Goede
2016-06-07 21:24 ` Maxime Ripard [this message]
2016-06-08 13:23   ` Hans de Goede
2016-06-11 15:45     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607212419.GE14179@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox