linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dmaengine: bcm2835: fix unexported function
@ 2016-06-07 16:14 Ben Dooks
  2016-06-07 20:23 ` Eric Anholt
  2016-06-08  3:37 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2016-06-07 16:14 UTC (permalink / raw)
  To: linux-arm-kernel

The bcm2835_dma_prep_dma_memcpy() function is not exported
outside the driver, so make it static to avoid the following
warning:

drivers/dma/bcm2835-dma.c:616:32: warning: symbol 'bcm2835_dma_prep_dma_memcpy' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Lee Jones <lee@kernel.org>
Cc: Eric Anholt <eric@anholt.net>
Cc: dmaengine at vger.kernel.org
Cc: linux-rpi-kernel at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
---
 drivers/dma/bcm2835-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 6149b27..9ecb942 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -613,7 +613,7 @@ static void bcm2835_dma_issue_pending(struct dma_chan *chan)
 	spin_unlock_irqrestore(&c->vc.lock, flags);
 }
 
-struct dma_async_tx_descriptor *bcm2835_dma_prep_dma_memcpy(
+static struct dma_async_tx_descriptor *bcm2835_dma_prep_dma_memcpy(
 	struct dma_chan *chan, dma_addr_t dst, dma_addr_t src,
 	size_t len, unsigned long flags)
 {
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] dmaengine: bcm2835: fix unexported function
  2016-06-07 16:14 [PATCH] dmaengine: bcm2835: fix unexported function Ben Dooks
@ 2016-06-07 20:23 ` Eric Anholt
  2016-06-08  3:37 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Anholt @ 2016-06-07 20:23 UTC (permalink / raw)
  To: linux-arm-kernel

Ben Dooks <ben.dooks@codethink.co.uk> writes:

> The bcm2835_dma_prep_dma_memcpy() function is not exported
> outside the driver, so make it static to avoid the following
> warning:
>
> drivers/dma/bcm2835-dma.c:616:32: warning: symbol 'bcm2835_dma_prep_dma_memcpy' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Reviewed-by: Eric Anholt <eric@anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160607/3d61cfcc/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] dmaengine: bcm2835: fix unexported function
  2016-06-07 16:14 [PATCH] dmaengine: bcm2835: fix unexported function Ben Dooks
  2016-06-07 20:23 ` Eric Anholt
@ 2016-06-08  3:37 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2016-06-08  3:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jun 07, 2016 at 05:14:56PM +0100, Ben Dooks wrote:
> The bcm2835_dma_prep_dma_memcpy() function is not exported
> outside the driver, so make it static to avoid the following
> warning:

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-08  3:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 16:14 [PATCH] dmaengine: bcm2835: fix unexported function Ben Dooks
2016-06-07 20:23 ` Eric Anholt
2016-06-08  3:37 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).