From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/4] ARM: mxs: dts: Add SanDisk Sansa Fuze+ support
Date: Thu, 9 Jun 2016 10:13:41 +0800 [thread overview]
Message-ID: <20160609021341.GA15413@tiger> (raw)
In-Reply-To: <5758C6A8.2060903@denx.de>
On Thu, Jun 09, 2016 at 03:30:16AM +0200, Marek Vasut wrote:
> On 06/09/2016 03:21 AM, Shawn Guo wrote:
> > On Sun, May 08, 2016 at 10:50:21PM +0200, Marek Vasut wrote:
> >> + regulators {
> >> + compatible = "simple-bus";
> >> +
> >> + reg_vddio_sd0: vddio-sd0 {
> >
> > Put fixed regulator nodes directly under root with suggested naming
> > scheme.
> >
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "vddio-sd0";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + gpio = <&gpio0 8 0>;
> >> + };
> >> +
> >> + reg_vddio_sd1: vddio-sd1 {
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "vddio-sd1";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + gpio = <&gpio1 29 0>;
> >> + };
> >> +
> >> + reg_vdd_touchpad: vdd-touchpad0 {
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "vdd-touchpad0";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + gpio = <&gpio0 26 0>;
> >> + regulator-always-on;
> >> + enable-active-low;
> >> + };
> >> +
> >> + reg_vdd_tuner: vdd-tuner0 {
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "vdd-tuner0";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + gpio = <&gpio0 29 0>;
> >> + regulator-always-on;
> >> + enable-active-low;
> >> + };
> >> + };
> >> +
> >> + backlight {
> >> + compatible = "pwm-backlight";
> >> + pwms = <&pwm 2 5000000>;
> >> + brightness-levels = <0 4 8 16 32 64 128 255>;
> >> + default-brightness-level = <6>;
> >> + };
> >> +
> >> + i2c at 0 {
> >
> > The @unit-address should be used for nodes with 'reg' property.
>
> Can you please do such minor fixes when applying or do you expect a resend ?
Such minor fixes are just too many to be fixed by myself. Please
resend.
Shawn
next prev parent reply other threads:[~2016-06-09 2:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 20:50 [PATCH 1/4] ARM: mxs: dts: Add SSP2 SD mux Marek Vasut
2016-05-08 20:50 ` [PATCH 2/4] ARM: mxs: dts: Add AUART2 pinmux Marek Vasut
2016-05-08 20:50 ` [PATCH V2 3/4] ARM: mxs: dts: Add Creative X-Fi3 support Marek Vasut
2016-05-09 16:59 ` Stefan Wahren
2016-06-06 8:45 ` Shawn Guo
2016-06-06 13:12 ` Marek Vasut
2016-05-08 20:50 ` [PATCH V2 4/4] ARM: mxs: dts: Add SanDisk Sansa Fuze+ support Marek Vasut
2016-06-09 1:21 ` Shawn Guo
2016-06-09 1:30 ` Marek Vasut
2016-06-09 2:13 ` Shawn Guo [this message]
2016-06-09 2:18 ` Marek Vasut
2016-06-09 2:42 ` Shawn Guo
2016-06-09 19:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609021341.GA15413@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).