linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: orion: remove unreferenced board-d2net.c
Date: Thu, 9 Jun 2016 15:31:16 +0200	[thread overview]
Message-ID: <20160609133116.GH30205@lunn.ch> (raw)
In-Reply-To: <1465466656-30002-1-git-send-email-ben.dooks@codethink.co.uk>

On Thu, Jun 09, 2016 at 11:04:16AM +0100, Ben Dooks wrote:
> Either this has been mis-converted (and needs to be fixed) or
> is no longer referenced and can be safely removed.

Hi Thomas

You added this code, which Ben is removing. It does look like you
forgot to call d2net_init() from orion5x_dt_init().

Please could you look at this.

       Thanks
  	Andrew

  reply	other threads:[~2016-06-09 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 10:04 [PATCH] ARM: orion: remove unreferenced board-d2net.c Ben Dooks
2016-06-09 13:31 ` Andrew Lunn [this message]
2016-06-09 13:39   ` Thomas Petazzoni
2016-06-09 14:10     ` Andrew Lunn
2016-06-09 14:12       ` Thomas Petazzoni
2016-06-09 15:52         ` Ben Dooks
2016-06-09 16:36           ` Andrew Lunn
2016-06-10 12:49             ` Simon Guinot
2016-07-27 14:42     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609133116.GH30205@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).