From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arm64: dts: msm8916: Add spc compat tag
Date: Fri, 10 Jun 2016 16:48:57 +0100 [thread overview]
Message-ID: <20160610154857.GA6430@leverpostej> (raw)
In-Reply-To: <1463634020-17252-4-git-send-email-andy.gross@linaro.org>
[+ Lorenzo]
On Thu, May 19, 2016 at 12:00:18AM -0500, Andy Gross wrote:
> This patch adds the qcom,idle-state-spc compatible to the SPC idle
> state. This compatible indicates that the state is one which supports
> freeze.
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 208af00..032e411 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -104,7 +104,7 @@
>
> idle-states {
> CPU_SPC: spc {
> - compatible = "arm,idle-state";
> + compatible = "qcom,idle-state-spc", "arm,idle-state";
> arm,psci-suspend-param = <0x40000002>;
> entry-latency-us = <130>;
> exit-latency-us = <150>;
This looks suspicious.
This is a PSCI idle state, and we have a PSCI driver driven by the
generic ARM cpuidle driver.
Why do we need a qcom-specific compatible here?
Surely we should be able to use the idle code in a generic fashion to
driver suspend-to-idle?
Thank,
Mark.
next prev parent reply other threads:[~2016-06-10 15:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 5:00 [PATCH 0/5] Qualcomm Suspend to Idle Support Andy Gross
2016-05-19 5:00 ` [PATCH 1/5] soc: qcom: Add suspend to idle support Andy Gross
2016-06-09 7:39 ` Ulf Hansson
2016-06-09 18:09 ` Andy Gross
2016-06-10 8:47 ` Ulf Hansson
2016-06-10 15:26 ` Andy Gross
2016-06-13 16:12 ` Daniel Lezcano
2016-05-19 5:00 ` [PATCH 2/5] arm: defconfig: Enable PM8941 pwr key Andy Gross
2016-06-10 20:25 ` Bjorn Andersson
2016-05-19 5:00 ` [PATCH 3/5] arm64: dts: msm8916: Add spc compat tag Andy Gross
2016-05-19 19:52 ` Stanimir Varbanov
2016-05-19 20:16 ` Andy Gross
2016-06-10 15:48 ` Mark Rutland [this message]
2016-06-10 16:12 ` Andy Gross
2016-06-10 16:25 ` Mark Rutland
2016-06-10 16:47 ` Andy Gross
2016-06-10 21:16 ` Lina Iyer
2016-06-10 21:52 ` Andy Gross
2016-06-13 11:00 ` Mark Rutland
2016-06-13 13:48 ` Lorenzo Pieralisi
2016-06-16 8:12 ` Andy Gross
2016-06-10 16:31 ` Lorenzo Pieralisi
2016-06-10 16:52 ` Andy Gross
2016-06-10 17:06 ` Lorenzo Pieralisi
2016-06-10 17:27 ` Andy Gross
2016-06-10 20:59 ` Lorenzo Pieralisi
2016-05-19 5:00 ` [PATCH 4/5] ARM: dts: qcom: Remove size elements from pmic reg Andy Gross
2016-06-10 20:26 ` Bjorn Andersson
2016-05-19 5:00 ` [PATCH 5/5] ARM: dts: qcom: pma8084: Add pwrkey entry Andy Gross
2016-06-10 20:29 ` Bjorn Andersson
2016-05-20 6:09 ` [PATCH 0/5] Qualcomm Suspend to Idle Support Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610154857.GA6430@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).