linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: disable plain NEON implementation of AES
@ 2016-06-13 14:57 Ard Biesheuvel
  2016-06-14 17:28 ` Olof Johansson
  0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2016-06-13 14:57 UTC (permalink / raw)
  To: linux-arm-kernel

The plain NEON implementation of AES is only suited for v8 cores that lack
the ARMv8 Crypto Extensions but have an implementation of the NEON tbl/tbx
instruction that is not pathetically slow. Unfortunately, this is currently
the empty set, so there is no point in including this implementation by
default. So disable it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index fd2d74d0491e..ab76f74e859b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -343,5 +343,5 @@ CONFIG_CRYPTO_SHA2_ARM64_CE=y
 CONFIG_CRYPTO_GHASH_ARM64_CE=y
 CONFIG_CRYPTO_AES_ARM64_CE_CCM=y
 CONFIG_CRYPTO_AES_ARM64_CE_BLK=y
-CONFIG_CRYPTO_AES_ARM64_NEON_BLK=y
+# CONFIG_CRYPTO_AES_ARM64_NEON_BLK is not set
 CONFIG_CRYPTO_CRC32_ARM64=y
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] arm64: defconfig: disable plain NEON implementation of AES
  2016-06-13 14:57 [PATCH] arm64: defconfig: disable plain NEON implementation of AES Ard Biesheuvel
@ 2016-06-14 17:28 ` Olof Johansson
  0 siblings, 0 replies; 2+ messages in thread
From: Olof Johansson @ 2016-06-14 17:28 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jun 13, 2016 at 04:57:22PM +0200, Ard Biesheuvel wrote:
> The plain NEON implementation of AES is only suited for v8 cores that lack
> the ARMv8 Crypto Extensions but have an implementation of the NEON tbl/tbx
> instruction that is not pathetically slow. Unfortunately, this is currently
> the empty set, so there is no point in including this implementation by
> default. So disable it.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Applied, thanks.


-Olof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-14 17:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-13 14:57 [PATCH] arm64: defconfig: disable plain NEON implementation of AES Ard Biesheuvel
2016-06-14 17:28 ` Olof Johansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).