public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO
@ 2016-06-15 16:34 Diego Dorta
  2016-06-15 16:59 ` Fabio Estevam
  2016-06-16  2:05 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Diego Dorta @ 2016-06-15 16:34 UTC (permalink / raw)
  To: linux-arm-kernel

According to the imx6ul-pico-hobbit schematics the Ethernet PHY reset GPIO
is GPIO1_28, so fix it accordingly.

Also adjust the reset duration to 1ms, because the KSZ8081 datasheet
requires 500?s.

Signed-off-by: Diego Dorta <diego.dorta@nxp.com>
---
 arch/arm/boot/dts/imx6ul-pico-hobbit.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
index 8ce1fec..e760cda 100644
--- a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
+++ b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
@@ -151,8 +151,8 @@
 	phy-mode = "rmii";
 	phy-handle = <&ethphy1>;
 	status = "okay";
-	phy-reset-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>;
-	phy-reset-duration = <11>;
+	phy-reset-gpios = <&gpio1 28 GPIO_ACTIVE_LOW>;
+	phy-reset-duration = <1>;
 
 	mdio {
 		#address-cells = <1>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO
  2016-06-15 16:34 [PATCH] ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO Diego Dorta
@ 2016-06-15 16:59 ` Fabio Estevam
  2016-06-16  2:05 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-06-15 16:59 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jun 15, 2016 at 1:34 PM, Diego Dorta <diego.dorta@nxp.com> wrote:
> According to the imx6ul-pico-hobbit schematics the Ethernet PHY reset GPIO
> is GPIO1_28, so fix it accordingly.
>
> Also adjust the reset duration to 1ms, because the KSZ8081 datasheet
> requires 500?s.
>
> Signed-off-by: Diego Dorta <diego.dorta@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO
  2016-06-15 16:34 [PATCH] ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO Diego Dorta
  2016-06-15 16:59 ` Fabio Estevam
@ 2016-06-16  2:05 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2016-06-16  2:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jun 15, 2016 at 01:34:41PM -0300, Diego Dorta wrote:
> According to the imx6ul-pico-hobbit schematics the Ethernet PHY reset GPIO
> is GPIO1_28, so fix it accordingly.
> 
> Also adjust the reset duration to 1ms, because the KSZ8081 datasheet
> requires 500?s.
> 
> Signed-off-by: Diego Dorta <diego.dorta@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-16  2:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-15 16:34 [PATCH] ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO Diego Dorta
2016-06-15 16:59 ` Fabio Estevam
2016-06-16  2:05 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox