From: panand@redhat.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Simple fix to the ARM kexec tools implementation
Date: Tue, 21 Jun 2016 11:41:28 +0530 [thread overview]
Message-ID: <20160621061128.GC29309@dhcppc9> (raw)
In-Reply-To: <20160617194405.GN1041@n2100.armlinux.org.uk>
On 17/06/2016:08:44:05 PM, Russell King - ARM Linux wrote:
> This is the "simple" fix for the ARM kexec tools code, which makes
> the code actually do what the comments describe.
>
> There are two problems:
>
> 1. When placing the initrd, we do not take account of the 32k offset
> that is required for the kernel image.
>
> 2. The code claims to allow the zImage decompressor to expand by a
> factor of 4, but only allows space for a factor of 3, since the
> decompressor itself has to fit in this memory space as well.
>
> Changing the code to follow the comments allows Keystone II to kexec
> with DEBUG_RODATA enabled, at least with the kernel I've been testing
> with.
>
> This is a stop-gap solution until a better solution can be implemented.
Yes, so until we have proper header for zImage, these patches looks fine to me.
For both of the patches:
Reviewed-by: Pratyush Anand <panand@redhat.com>
>
> kexec/arch/arm/kexec-zImage-arm.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
next prev parent reply other threads:[~2016-06-21 6:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 19:44 [PATCH 0/2] Simple fix to the ARM kexec tools implementation Russell King - ARM Linux
2016-06-17 19:44 ` [PATCH 1/2] arm: take account of TEXT_OFFSET for subsequent images Russell King
2016-06-17 19:44 ` [PATCH 2/2] arm: fix kernel image size Russell King
2016-06-21 7:43 ` Tony Lindgren
2016-06-21 9:47 ` Russell King - ARM Linux
2016-06-21 10:38 ` Tony Lindgren
2016-06-21 10:57 ` Tony Lindgren
2016-06-21 15:44 ` Russell King - ARM Linux
2016-06-21 16:55 ` Tony Lindgren
2016-06-21 21:51 ` Russell King - ARM Linux
2016-06-22 7:36 ` Tony Lindgren
2016-06-22 8:29 ` Russell King - ARM Linux
2016-06-22 8:51 ` Tony Lindgren
2016-06-21 11:02 ` Mason
2016-06-21 6:11 ` Pratyush Anand [this message]
2016-06-21 8:20 ` [PATCH 0/2] Simple fix to the ARM kexec tools implementation Russell King - ARM Linux
2016-06-23 0:41 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621061128.GC29309@dhcppc9 \
--to=panand@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).