From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: camera application for testing (was Re: v4l subdevs without big device)
Date: Wed, 22 Jun 2016 13:52:18 +0200 [thread overview]
Message-ID: <20160622115218.GA27606@amd> (raw)
In-Reply-To: <1500395.gQ70N9eqVS@avalon>
Hi!
> > I think libv4l itself has algorithms to control at least some of these. It
> > relies on the image data so the CPU time consumption will be high.
> >
> > AFAIR Laurent has also worked on implementing some algorithms that use the
> > histogram and some of the statistics. Add him to cc list.
>
> http://git.ideasonboard.org/omap3-isp-live.git
>
> That's outdated and might not run or compile anymore. The code is
> more of a
Lets see, it compiles with this hack:
index 6f3ffbe..935f41d 100644
--- a/isp/v4l2.c
+++ b/isp/v4l2.c
@@ -292,7 +292,7 @@ struct v4l2_device *v4l2_open(const char *devname)
* driver (>= v3.19) will set both CAPTURE and OUTPUT in the
* capabilities field.
*/
- capabilities = cap.device_caps ? : cap.capabilities;
+ capabilities = /* cap.device_caps ? : */ cap.capabilities;
if (capabilities & V4L2_CAP_VIDEO_CAPTURE)
dev->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
I can try to run it, but I guess I'll need kernel with camera support.
pavel at n900:/my/omap3-isp-live$ LD_LIBRARY_PATH=isp ./snapshot
media_open: Can't open media device /dev/media0
error: unable to open media device /dev/media0
Segmentation fault (core dumped)
I tried again on kernel with camera:
pavel at n900:/my/omap3-isp-live$ LD_LIBRARY_PATH=isp ./snapshot
error: unable to locate sensor.
Segmentation fault (core dumped)
pavel at n900:/my/omap3-isp-live$
Here's the fix for coredump:
diff --git a/isp/subdev.c b/isp/subdev.c
index 9b36234..c74514e 100644
--- a/isp/subdev.c
+++ b/isp/subdev.c
@@ -75,6 +75,8 @@ int v4l2_subdev_open(struct media_entity *entity)
void v4l2_subdev_close(struct media_entity *entity)
{
+ if (!entity)
+ return;
if (entity->fd == -1)
return;
Let me investigate some more.
> proof of concept implementation, but it could be used as a starting point.
> With an infinite amount of free time I'd love to work on an open-source
> project for computational cameras, integrating it with libv4l.
For the record, I pushed my code to
https://gitlab.com/pavelm/fcam-dev
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2016-06-22 11:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 8:45 drivers/media/i2c/adp1653.c: does not show as /dev/video* or v4l-subdev* Pavel Machek
2016-04-29 7:15 ` v4l subdevs without big device was " Pavel Machek
2016-04-29 7:31 ` Hans Verkuil
2016-04-29 7:56 ` Sakari Ailus
2016-04-29 9:50 ` Pavel Machek
2016-04-29 10:59 ` Sakari Ailus
2016-04-29 11:05 ` Pali Rohár
2016-04-29 11:23 ` Sakari Ailus
2016-04-29 14:06 ` Pavel Machek
2016-04-29 10:15 ` Pavel Machek
2016-04-29 21:30 ` [pre-rfc] focus and flash for Nokia N900 (was Re: v4l subdevs without big device was Re: drivers/media/i2c/adp1653.c: does not show as /dev/video* or v4l-subdev*) Pavel Machek
2016-04-29 22:13 ` camera application for testing (was Re: v4l subdevs without big device) Pavel Machek
2016-04-29 22:20 ` Pali Rohár
2016-04-29 22:47 ` Ivaylo Dimitrov
2016-05-01 14:08 ` Sakari Ailus
2016-05-01 19:21 ` Pavel Machek
2016-06-21 22:32 ` Pavel Machek
2016-06-21 23:59 ` Laurent Pinchart
2016-06-22 11:52 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622115218.GA27606@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).