From: konrad@darnok.org (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64:swiotlb:Enable only when Input size through command line
Date: Fri, 24 Jun 2016 06:46:20 -0400 [thread overview]
Message-ID: <20160624104619.GA4378@localhost.localdomain> (raw)
In-Reply-To: <20160624105729.095e7f1f@xhacker>
On Fri, Jun 24, 2016 at 10:57:29AM +0800, Jisheng Zhang wrote:
> Dear Konrad,
>
> On Thu, 23 Jun 2016 12:06:10 -0400 Konrad Rzeszutek Wilk wrote:
>
> > On June 23, 2016 10:30:34 AM EDT, Catalin Marinas <catalin.marinas@arm.com> wrote:
> > >On Thu, Jun 23, 2016 at 05:43:40PM +0530, Manjeet Pawar wrote:
> > >> From: Rohit Thapliyal <r.thapliyal@samsung.com>
> > >>
> > >> swiotlb default size of 64M is too big as
> > >> default value therefore it is made configurable
> > >> through command line through swiotlb_size parameter.
> > >> swiotlb allocation shall be done only when the
> > >> swiotlb size is given through command line.
> > >> Otherwise no swiotlb is allocated.
> > >
> > >I already queued this patch:
> > >
> > >http://lkml.kernel.org/g/1465372426-4077-1-git-send-email-jszhang at marvell.com
> > >
> > >If you have any objections to it, please reply there.
> >
> >
> > I do (sorry about duplicate email, the other got rejected by mailing lists).
> >
> > Why not expand the swiotlb= parameter instead of introducing a new one?
>
> Do you mean pass "swiotlb=" for those platforms(most probably, arm64 with less
> than 4GB DDR) which don't need swiotlb? I'm afraid this is not convenient, and
Why not just have a function that checks the amount of memory? x86 has
that - if it finds that the machine has less than 4GB it will not setup
SWIOTLB?
> users even don't notice swiotlb parameter. From another side, pass "swiotlb=0"
> will make the swiotlb reserve 64MB instead, so how can we achieve zero reserved
> memory for swiotlb through "swiotlb=" parameter?
Obviously make the function understand that 0 is to turn it off.
>
> PS: my patch didn't introduce new boot parameter.
swiotlb_sz ?
>
> I'm not sure I got your meaning, so could you please comment my patch
> directly?
>
> Thanks,
> Jisheng
>
> >
> > Also, why not use the swiotlb by itself? That does the job as well?
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2016-06-24 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 12:13 [PATCH] arm64:swiotlb:Enable only when Input size through command line Manjeet Pawar
2016-06-23 12:31 ` Robin Murphy
2016-06-23 14:30 ` Catalin Marinas
2016-06-23 16:06 ` Konrad Rzeszutek Wilk
2016-06-24 2:57 ` Jisheng Zhang
2016-06-24 10:46 ` Konrad Rzeszutek Wilk [this message]
2016-06-24 10:53 ` Robin Murphy
2016-06-23 14:38 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624104619.GA4378@localhost.localdomain \
--to=konrad@darnok.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).