From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / suspend: show workqueues busy name in suspend flow
Date: Wed, 29 Jun 2016 09:22:01 -0400 [thread overview]
Message-ID: <20160629132201.GC24054@htj.duckdns.org> (raw)
In-Reply-To: <1467172451.4141.20.camel@mtksdaap41>
Hello, Roger.
On Wed, Jun 29, 2016 at 11:54:11AM +0800, Roger Lu wrote:
> Please allow me to elaborate my previous concern about printing
> freezable workqueue info only in this case.
>
> The benefit of it is that debugger can quickly understand which
> freezable workqueues block suspend flow and assign this issue to
> corresponding owner instead of extracting freezable workqueue info from
> show_workqueue_state() first and, then, assigning the issue.
I don't think it matters. At that point, workqueues are generally
pretty idle anyway and it shouldn't be difficult to tell which work
items are the offending ones. Besides, freezable and unfreezable
workqueues share the same backend pools, so it isn't easily separable
either.
Thanks.
--
tejun
prev parent reply other threads:[~2016-06-29 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1466586509-32400-1-git-send-email-roger.lu@mediatek.com>
2016-06-22 15:21 ` [PATCH] PM / suspend: show workqueues busy name in suspend flow Tejun Heo
[not found] ` <1467020645.25092.24.camel@mtksdaap41>
2016-06-28 16:56 ` Tejun Heo
2016-06-29 3:54 ` Roger Lu
2016-06-29 13:22 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629132201.GC24054@htj.duckdns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).