From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: remove unnecessary BUG_ON
Date: Thu, 30 Jun 2016 16:50:28 +0100 [thread overview]
Message-ID: <20160630154952.GB29700@leverpostej> (raw)
In-Reply-To: <1467252124-19625-1-git-send-email-wangkefeng.wang@huawei.com>
On Thu, Jun 30, 2016 at 10:02:04AM +0800, Kefeng Wang wrote:
> The memblock_alloc() and memblock_alloc_base() will panic on their own
> if no free memory, remove pointless BUG_ON.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
For some reason I thought we'd already removed this. FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
I believe it's up to Catalin to pick this up.
Mark.
> ---
> arch/arm64/mm/mmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index 0f85a46..d120abc 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -77,7 +77,6 @@ static phys_addr_t __init early_pgtable_alloc(void)
> void *ptr;
>
> phys = memblock_alloc(PAGE_SIZE, PAGE_SIZE);
> - BUG_ON(!phys);
>
> /*
> * The FIX_{PGD,PUD,PMD} slots may be in active use, but the FIX_PTE
> --
> 2.6.0.GIT
>
next prev parent reply other threads:[~2016-06-30 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 2:02 [PATCH] arm64: mm: remove unnecessary BUG_ON Kefeng Wang
2016-06-30 15:50 ` Mark Rutland [this message]
2016-06-30 16:55 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630154952.GB29700@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox