From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: fix error handling
Date: Mon, 4 Jul 2016 11:51:02 +0300 [thread overview]
Message-ID: <20160704085102.GF32301@mwanda> (raw)
In-Reply-To: <577A15D2.5010103@ti.com>
On Mon, Jul 04, 2016 at 01:22:50PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote:
> > I will resubmit in the coming days.
> >
> > return PTR_ERR(phy->clk);
> > should also be updated.
>
> while at that, also fix your $subject to something like
> "phy: sun9i-usb: fix error handling"
>
Yes. Also the first patch should have used that same prefix.
9c3b44302636 ('phy: Add driver to support individual USB PHYs on sun9i')
We have this problem quite often, but other subsystems have fixed it
because they start using the correct prefix when the driver is added.
The second patch for this driver had the same issue:
9c3b44302636 ('phy: Add driver to support individual USB PHYs on sun9i')
regards,
dan carpenter
next prev parent reply other threads:[~2016-07-04 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 5:55 [PATCH] phy: fix error handling Christophe JAILLET
2016-07-03 20:04 ` Maxime Ripard
2016-07-03 21:08 ` Christophe JAILLET
2016-07-04 7:52 ` Kishon Vijay Abraham I
2016-07-04 8:51 ` Dan Carpenter [this message]
2016-07-04 8:58 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704085102.GF32301@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).