* [PATCH] clocksource: timer-atmel-pit: enable mck
@ 2016-07-04 16:00 Alexandre Belloni
2016-07-04 20:24 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2016-07-04 16:00 UTC (permalink / raw)
To: linux-arm-kernel
mck is needed to get the PIT working. Explicitly prepare_enable it instead
of assuming it is enabled.
This solves an issue were the system is freezing when the ETM/ETB drivers
are enabled.
Reported-by: Olivier Schonken <olivier.schonken@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/clocksource/timer-atmel-pit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index d911c5dca8f1..fcc97711cd79 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -248,6 +248,9 @@ static void __init at91sam926x_pit_dt_init(struct device_node *node)
if (IS_ERR(data->mck))
panic(pr_fmt("Unable to get mck clk\n"));
+ if (clk_prepare_enable(data->mck))
+ panic(pr_fmt("Unable to enable mck\n"));
+
/* Get the interrupts property */
data->irq = irq_of_parse_and_map(node, 0);
if (!data->irq)
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] clocksource: timer-atmel-pit: enable mck
2016-07-04 16:00 [PATCH] clocksource: timer-atmel-pit: enable mck Alexandre Belloni
@ 2016-07-04 20:24 ` Boris Brezillon
2016-07-05 7:47 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2016-07-04 20:24 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 4 Jul 2016 18:00:09 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> mck is needed to get the PIT working. Explicitly prepare_enable it instead
> of assuming it is enabled.
>
> This solves an issue were the system is freezing when the ETM/ETB drivers
^ where
> are enabled.
>
> Reported-by: Olivier Schonken <olivier.schonken@gmail.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/clocksource/timer-atmel-pit.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
> index d911c5dca8f1..fcc97711cd79 100644
> --- a/drivers/clocksource/timer-atmel-pit.c
> +++ b/drivers/clocksource/timer-atmel-pit.c
> @@ -248,6 +248,9 @@ static void __init at91sam926x_pit_dt_init(struct device_node *node)
> if (IS_ERR(data->mck))
> panic(pr_fmt("Unable to get mck clk\n"));
>
> + if (clk_prepare_enable(data->mck))
> + panic(pr_fmt("Unable to enable mck\n"));
> +
> /* Get the interrupts property */
> data->irq = irq_of_parse_and_map(node, 0);
> if (!data->irq)
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] clocksource: timer-atmel-pit: enable mck
2016-07-04 20:24 ` Boris Brezillon
@ 2016-07-05 7:47 ` Nicolas Ferre
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2016-07-05 7:47 UTC (permalink / raw)
To: linux-arm-kernel
Le 04/07/2016 22:24, Boris Brezillon a ?crit :
> On Mon, 4 Jul 2016 18:00:09 +0200
> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>
>> mck is needed to get the PIT working. Explicitly prepare_enable it instead
>> of assuming it is enabled.
>>
>> This solves an issue were the system is freezing when the ETM/ETB drivers
>
> ^ where
>
>> are enabled.
>>
>> Reported-by: Olivier Schonken <olivier.schonken@gmail.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> drivers/clocksource/timer-atmel-pit.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
>> index d911c5dca8f1..fcc97711cd79 100644
>> --- a/drivers/clocksource/timer-atmel-pit.c
>> +++ b/drivers/clocksource/timer-atmel-pit.c
>> @@ -248,6 +248,9 @@ static void __init at91sam926x_pit_dt_init(struct device_node *node)
>> if (IS_ERR(data->mck))
>> panic(pr_fmt("Unable to get mck clk\n"));
>>
>> + if (clk_prepare_enable(data->mck))
>> + panic(pr_fmt("Unable to enable mck\n"));
>> +
>> /* Get the interrupts property */
>> data->irq = irq_of_parse_and_map(node, 0);
>> if (!data->irq)
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-05 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04 16:00 [PATCH] clocksource: timer-atmel-pit: enable mck Alexandre Belloni
2016-07-04 20:24 ` Boris Brezillon
2016-07-05 7:47 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).