Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()
Date: Thu, 07 Jul 2016 11:34:43 +0900	[thread overview]
Message-ID: <20160707023443.GF23620@samsunx.samsung> (raw)
In-Reply-To: <577D0316.1050502@samsung.com>

Hi,

just a question,

> >  	pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
> > -	if (IS_ERR(pdev))
> > -		return PTR_ERR(pdev);
> > +	if (!pdev)
> > +		return -ENOMEM;
> >  
> >  	/*
> >  	 * use the first registered sysmmu device for performing
> > 
> 

is ENOMEM the right return value? of_platform_device_create()
doesn't fail only in case of malloc failure.

Shouldn't it be ENODEV instead, which might also mean with some
imagination that there is no memory available for that device?

Thanks,
Andi

> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

  reply	other threads:[~2016-07-07  2:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 12:15 [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup() weiyj_lk at 163.com
2016-07-06 12:47 ` Dennis Chen
2016-07-06 13:09 ` Krzysztof Kozlowski
2016-07-07  2:34   ` Andi Shyti [this message]
2016-07-07  2:50     ` Wei Yongjun
2016-07-18  7:34   ` Marek Szyprowski
2016-07-07  2:59 ` [PATCH -next v2] " weiyj_lk at 163.com
2016-07-07  4:25   ` Andi Shyti
2016-07-07  9:43   ` Krzysztof Kozlowski
2016-07-07 12:09     ` Wei Yongjun
2016-07-07 12:17   ` [PATCH -next v3] " weiyj_lk at 163.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160707023443.GF23620@samsunx.samsung \
    --to=andi.shyti@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox