From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: s3c64xx: do not disable the clock while configuring the spi
Date: Thu, 07 Jul 2016 18:58:41 +0900 [thread overview]
Message-ID: <20160707095840.GH23620@samsunx.samsung> (raw)
In-Reply-To: <1467876237-12183-1-git-send-email-andi.shyti@samsung.com>
Hi,
> if (sdd->port_conf->clk_from_cmu) {
> - /* Configure Clock */
> - /* There is half-multiplier before the SPI */
> clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
sorry, I will re-send it because I should not remove the comments
above.... in the future someone might wonder why it's multiplied
by 2.
That's called auto review and auto-nack :)
Andi
> - /* Enable Clock */
> - clk_prepare_enable(sdd->src_clk);
> } else {
> /* Configure Clock */
> val = readl(regs + S3C64XX_SPI_CLK_CFG);
> --
> 2.8.1
>
next prev parent reply other threads:[~2016-07-07 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160707072419epcas1p3ba881fb9b3270eb8cde87380aea7bcf9@epcas1p3.samsung.com>
2016-07-07 7:23 ` [PATCH] spi: s3c64xx: do not disable the clock while configuring the spi Andi Shyti
2016-07-07 9:41 ` Krzysztof Kozlowski
2016-07-07 9:58 ` Andi Shyti [this message]
2016-07-07 12:24 ` Mark Brown
2016-07-07 10:01 ` Applied "spi: s3c64xx: do not disable the clock while configuring the spi" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707095840.GH23620@samsunx.samsung \
--to=andi.shyti@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox