From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] serial: amba-pl011: complete support to ZTE uart
Date: Thu, 7 Jul 2016 23:01:07 +0800 [thread overview]
Message-ID: <20160707150107.GA20896@tiger> (raw)
In-Reply-To: <20160707095453.GA10000@tiger>
On Thu, Jul 07, 2016 at 05:54:53PM +0800, Shawn Guo wrote:
> On Mon, May 16, 2016 at 10:31:37AM +0800, Jun Nie wrote:
> > >> > Russell,
> > >> >
> > >> > Do you have any comments to these change?
> > >> >
> > >> > Jun
> > >>
> > >> Greg,
> > >>
> > >> Do you have any idea on how to drive review on this patch? Seems
> > >> maintainer Russell is too busy and missing for this thread and others
> > >> do not have comments. Your comments are appreciated!
> > >
> > > I would like to get Russell's opinion of this before merging it.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Russell,
> >
> > Could you help have a look at this patch? Thanks!
>
> Hi Russell,
>
> I think this version of the patch is trying to address the comment you
> put on v1, i.e. instead of extending platform driver we should try to
> probe ZTE UART from AMBA bus.
>
> The solution here is to fake a AMBA peripheral ID which does not exist
> on hardware with a magic number. While it's working, it looks too
> hackish, and doesn't really scale in the long run. I hope that's also
> the reason you are unwilling to provide your ACK :)
>
> Unless you have a better solution to suggest, I would think that
> platform driver is a sensible way to support the device, and will go
> back to v1 approach.
Just found that Russell's email address changed. Resend to the new
address.
Shawn
next prev parent reply other threads:[~2016-07-07 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 7:12 [PATCH v2] serial: amba-pl011: complete support to ZTE uart Jun Nie
2016-04-01 9:53 ` Jun Nie
2016-04-12 13:01 ` Jun Nie
2016-04-25 6:53 ` Jun Nie
2016-04-28 20:11 ` Greg KH
2016-05-16 2:31 ` Jun Nie
2016-07-07 9:54 ` Shawn Guo
2016-07-07 15:01 ` Shawn Guo [this message]
2016-07-07 15:28 ` Russell King - ARM Linux
2016-07-08 2:11 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707150107.GA20896@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).