From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] arm64: implement FTRACE_WITH_REGS
Date: Fri, 8 Jul 2016 11:49:38 -0400 [thread overview]
Message-ID: <20160708114938.49052cee@gandalf.local.home> (raw)
In-Reply-To: <20160708152421.GG3556@pathway.suse.cz>
On Fri, 8 Jul 2016 17:24:21 +0200
Petr Mladek <pmladek@suse.com> wrote:
> On Fri 2016-07-08 17:07:09, Torsten Duwe wrote:
> > On Fri, Jul 08, 2016 at 04:58:00PM +0200, Petr Mladek wrote:
> > > On Mon 2016-06-27 17:17:17, Torsten Duwe wrote:
> > > > Once gcc is enhanced to optionally generate NOPs at the beginning
> > > > of each function, like the concept proven in
> > > > https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01671.html
> > > > (sans the "fprintf (... pad_size);", which spoils the data structure
> > > > for kernel use), the generated pads can nicely be used to reroute
> > > > function calls for tracing/profiling, or live patching.
> > > > diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c
> > > > index ebecf9a..917065c 100644
> > > > --- a/arch/arm64/kernel/ftrace.c
> > > > +++ b/arch/arm64/kernel/ftrace.c
> > > > @@ -39,6 +39,12 @@ static int ftrace_modify_code(unsigned long pc, u32 old, u32 new,
> > > > if (aarch64_insn_read((void *)pc, &replaced))
> > > > return -EFAULT;
> > > >
> > > > + /* If we already have what we'll finally want,
> > > > + * report success. This is needed on startup.
> > > > + */
> > > > + if (replaced == new)
> > > > + return 0;
> > >
> > > This looks strange. I wonder if it actually hides a real bug that we
> > > modify the code twice or so.
> >
> > Not at all. All "profilers" we abused so far generate code that needs to
> > be disabled on boot first. prolog-pad generates nops, initially.
>
> Yeah, but I cannot find this kind of check in other architectures.
> I checked arch/x86/kernel/ftrace.c, arch/s390/kernel/ftrace.c, and
> arch/powerpc/kernel/ftrace.c. These all support ftrace with
> regs and livepatching.
I guess the question is, with this approach, there's no call to mcount
or fentry at compile time? Just nops are added? In this case perhaps the
if statement should be more defined:
/*
* On boot, with the prologue code, the code will already
* be a nop.
*/
if (replace == new && new == NOP)
return 0;
And perhaps you can even pass in addr and check if it equals the nop
address. Maybe even not call this code then? That is, if addr ==
MCOUNT_ADDR passed in by ftrace_code_disable() have ftrace_make_nop()
simple return 0 without doing anything.
-- Steve
next prev parent reply other threads:[~2016-07-08 15:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 15:15 [PATCH v2 0/2] arm64 live patching Torsten Duwe
2016-06-27 15:17 ` [PATCH v2 1/2] arm64: implement FTRACE_WITH_REGS Torsten Duwe
2016-07-01 12:53 ` Josh Poimboeuf
2016-07-04 9:18 ` Torsten Duwe
2016-07-03 5:17 ` kbuild test robot
2016-07-08 14:58 ` Petr Mladek
2016-07-08 15:07 ` Torsten Duwe
2016-07-08 15:24 ` Petr Mladek
2016-07-08 15:48 ` Josh Poimboeuf
2016-07-08 15:57 ` Steven Rostedt
2016-07-08 20:24 ` Torsten Duwe
2016-07-08 21:08 ` Steven Rostedt
2016-07-09 9:06 ` Torsten Duwe
2016-07-15 18:36 ` Steven Rostedt
2016-07-08 15:49 ` Steven Rostedt [this message]
2016-06-27 15:17 ` [PATCH v2 2/2] arm64: implement live patching Torsten Duwe
2016-07-11 14:03 ` Miroslav Benes
2016-07-11 21:58 ` Jessica Yu
2016-07-12 9:47 ` Miroslav Benes
2016-07-13 0:11 ` [PATCH] arm64: take SHN_LIVEPATCH syms into account when calculating plt_max_entries Jessica Yu
2016-08-17 9:38 ` Miroslav Benes
2016-08-11 16:46 ` [PATCH v2 2/2] arm64: implement live patching Torsten Duwe
2016-07-15 16:03 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708114938.49052cee@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).