From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mtd: nand: omap2: Add check for old elm binding
Date: Sat, 9 Jul 2016 17:56:14 -0700 [thread overview]
Message-ID: <20160710005614.GB29572@localhost> (raw)
In-Reply-To: <1467711150-23356-2-git-send-email-t.remmet@phytec.de>
On Tue, Jul 05, 2016 at 11:32:30AM +0200, Teresa Remmet wrote:
> commit c9711ec5250b ("mtd: nand: omap: Clean up device tree support")
> removes the check for the old elm phandle binding.
That seems like a silly breakage of backwards compatibility. Must have
overlooked that one, sorry.
> Add it again to keep backward compatibility.
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
I think we should probably take this for v4.7, since the breaking commit
was only merged in v4.7-rc1. OMAP folks, any comment?
Brian
> ---
> drivers/mtd/nand/omap2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 08e1588..d788663 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1658,7 +1658,9 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info)
> /* detect availability of ELM module. Won't be present pre-OMAP4 */
> info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0);
> if (!info->elm_of_node)
> - dev_dbg(dev, "ti,elm-id not in DT\n");
> + info->elm_of_node = of_parse_phandle(child, "elm_id", 0);
> + if (!info->elm_of_node)
> + dev_dbg(dev, "ti,elm-id not in DT\n");
>
> /* select ecc-scheme for NAND */
> if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-07-10 0:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 9:32 [PATCH 1/2] ARM: dts: am335x: Update elm phandle binding Teresa Remmet
2016-07-05 9:32 ` [PATCH 2/2] mtd: nand: omap2: Add check for old elm binding Teresa Remmet
2016-07-10 0:56 ` Brian Norris [this message]
2016-07-13 17:13 ` Brian Norris
2016-08-01 9:22 ` Roger Quadros
2016-07-13 17:14 ` [PATCH 1/2] ARM: dts: am335x: Update elm phandle binding Brian Norris
2016-08-01 9:25 ` Roger Quadros
2016-08-15 16:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160710005614.GB29572@localhost \
--to=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).