linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry
Date: Mon, 11 Jul 2016 00:27:43 +0200	[thread overview]
Message-ID: <20160710222743.GN8426@lunn.ch> (raw)
In-Reply-To: <20160710204546.GS1041@n2100.armlinux.org.uk>

On Sun, Jul 10, 2016 at 09:45:46PM +0100, Russell King - ARM Linux wrote:
> On Sun, Jul 10, 2016 at 10:37:51PM +0200, Andrew Lunn wrote:
> > The armada-38x.dtsi has
> > 
> >                                 ref_clk0_pins: ref-clk-pins-0 {
> >                                         marvell,pins = "mpp45";
> >                                         marvell,function = "ref";
> >                                 };
> > 
> > which you could reference rather then defining it yourself.
> 
> Weren't these going to be deleted from the main SoC dtsi files,
> eventually?  I thought that was the idea, to prevent cluttering
> up the .dtb files with nodes which aren't ever used.

I've not heard they are going to be removed....

Having work on mvebu, and a Freescale Vybrid board, i see two
different styles. mvebu defines all the common pinctrl values in the
.dtsi file, so making the .dts file pretty minimalist. For the vybrid
board there was nothing in the .dtsi file, the dts file is huge, and i
made at least one error, missing at required pin which took me a while
to debug.

I would also say cluttered .dtb because of unused nodes it a compiler
issue. Why does it not optimise them out?

   Andrew

  reply	other threads:[~2016-07-10 22:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 15:27 [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry Russell King
2016-07-10 20:32 ` Andrew Lunn
2016-07-11 16:05   ` Gregory CLEMENT
2016-07-10 20:37 ` Andrew Lunn
2016-07-10 20:45   ` Russell King - ARM Linux
2016-07-10 22:27     ` Andrew Lunn [this message]
2016-07-10 22:38       ` Russell King - ARM Linux
2016-07-10 22:53         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160710222743.GN8426@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).