From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear voltage ranges
Date: Mon, 11 Jul 2016 14:50:09 -0700 [thread overview]
Message-ID: <20160711215009.4519-4-sboyd@codeaurora.org> (raw)
In-Reply-To: <20160711215009.4519-1-sboyd@codeaurora.org>
The pm8x41_hfsmps ranges overlap. The first range is from 375000
to 1562500:
375000 + (95 * 12500) == 1562500
and the second range starts at 1550000. Interestingly, the second
range ends at the correct value when it's set to be the
appropriate start value, 1575000:
1575000 + ((158 - 96) * 25000) == 3125000
Cc: Andy Gross <andy.gross@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Fixes: da65e367b67e ("regulator: Regulator driver for the Qualcomm RPM")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/regulator/qcom_smd-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 891ae44a49c2..8ed46a9a55c8 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -212,7 +212,7 @@ static const struct regulator_desc pma8084_switch = {
static const struct regulator_desc pm8x41_hfsmps = {
.linear_ranges = (struct regulator_linear_range[]) {
REGULATOR_LINEAR_RANGE( 375000, 0, 95, 12500),
- REGULATOR_LINEAR_RANGE(1550000, 96, 158, 25000),
+ REGULATOR_LINEAR_RANGE(1575000, 96, 158, 25000),
},
.n_linear_ranges = 2,
.n_voltages = 159,
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-07-11 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 21:50 [PATCH 0/3] Fixes for RPM SMD regulator voltage ranges Stephen Boyd
2016-07-11 21:50 ` [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Stephen Boyd
2016-07-11 22:48 ` Andy Gross
2016-08-05 0:58 ` Stephen Boyd
2016-08-05 4:09 ` Andy Gross
2016-08-05 12:09 ` Applied "regulator: qcom_smd: Fix voltage ranges for pm8x41" to the regulator tree Mark Brown
2016-08-13 4:00 ` Bjorn Andersson
2016-08-15 12:51 ` Mark Brown
2016-07-11 21:50 ` [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo Stephen Boyd
2016-07-11 22:38 ` Andy Gross
2016-08-05 0:57 ` Stephen Boyd
2016-08-05 4:09 ` Andy Gross
2016-08-05 12:09 ` Applied "regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo" to the regulator tree Mark Brown
2016-07-11 21:50 ` Stephen Boyd [this message]
2016-07-11 22:39 ` [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear voltage ranges Andy Gross
2016-07-12 9:02 ` Applied "regulator: qcom_smd: Avoid overlapping linear voltage ranges" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711215009.4519-4-sboyd@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).