linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: dts: imx25: substitute NO_PAD_CTL by the respective reset value
Date: Tue, 12 Jul 2016 09:38:59 +0200	[thread overview]
Message-ID: <20160712073859.GQ16643@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5ASsA88TQLAPdyit0xr3Lqh8e+8C_ZgoUa7w2rZxTb-ag@mail.gmail.com>

On Mon, Jul 11, 2016 at 07:56:15AM -0300, Fabio Estevam wrote:
> Hi Uwe,
> 
> On Mon, Jul 11, 2016 at 4:37 AM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> 
> >> Then we could later change each 0x80000000 occurrance by replacing it
> >> with the actual PAD register value instead of the power on defaults.
> >
> > Why later?
> 
> I was not sure if you had access to all these mx25 boards to verify
> the real values used on the pin configurations. I don't have access to
> mx25pdk today, but I can access it later this week.

I don't have access to these, but I took a look in the U-boot sources.

So on top of my patch I'd suggest the following change:

diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts
index cf41b726e2de..08caba550ee6 100644
--- a/arch/arm/boot/dts/imx25-pdk.dts
+++ b/arch/arm/boot/dts/imx25-pdk.dts
@@ -171,7 +171,7 @@
 			MX25_PAD_SD1_DATA2__SD1_DATA2		0x000000d1
 			MX25_PAD_SD1_DATA3__SD1_DATA3		0x000000d1
 			MX25_PAD_A14__GPIO_2_0			0x00000080
-			MX25_PAD_A15__GPIO_2_1			0x00000080
+			MX25_PAD_A15__GPIO_2_1			0x00000000
 		>;
 	};
 
@@ -187,14 +187,14 @@
 			MX25_PAD_FEC_RX_DV__FEC_RX_DV		0x000000c0
 			MX25_PAD_FEC_TX_CLK__FEC_TX_CLK		0x000001c0
 			MX25_PAD_A17__GPIO_2_3			0x00000000
-			MX25_PAD_D12__GPIO_4_8			0x000000a1
+			MX25_PAD_D12__GPIO_4_8			0x00000000
 		>;
 	};
 
 	pinctrl_i2c1: i2c1grp {
 		fsl,pins = <
-			MX25_PAD_I2C1_CLK__I2C1_CLK		0x000000a8
-			MX25_PAD_I2C1_DAT__I2C1_DAT		0x000000a8
+			MX25_PAD_I2C1_CLK__I2C1_CLK		0x000001e8
+			MX25_PAD_I2C1_DAT__I2C1_DAT		0x000001e8
 		>;
 	};
 
Did I miss anything?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2016-07-12  7:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 10:07 [PATCH 0/6] ARM: dts: imx cleanups Uwe Kleine-König
2016-07-10 10:07 ` [PATCH 1/6] ARM: dts: drop function device nodes for pinctrl-imx nodes Uwe Kleine-König
2016-07-10 10:07 ` [PATCH 2/6] ARM: dts: imx25: don't configure reserved pad settings Uwe Kleine-König
2016-07-10 10:07 ` [PATCH 3/6] ARM: dts: imx25: substitute NO_PAD_CTL by the respective reset value Uwe Kleine-König
2016-07-10 19:10   ` Fabio Estevam
2016-07-11  7:37     ` Uwe Kleine-König
2016-07-11 10:56       ` Fabio Estevam
2016-07-12  7:38         ` Uwe Kleine-König [this message]
2016-07-12 15:15           ` Fabio Estevam
2016-07-12 18:32             ` Fabio Estevam
2016-07-12 19:15               ` Uwe Kleine-König
2016-07-12 20:30                 ` Fabio Estevam
2016-07-12 20:40                   ` Fabio Estevam
2016-07-13  6:25                     ` Uwe Kleine-König
2016-07-13 16:18                       ` Fabio Estevam
2016-07-14 17:04                       ` Fabio Estevam
2016-07-14 18:34                         ` Uwe Kleine-König
2016-07-14 19:16                           ` Fabio Estevam
2016-07-14 19:21                             ` Uwe Kleine-König
2016-07-10 10:07 ` [PATCH 4/6] ARM: dts: imx6q: don't configure reserved pad settings Uwe Kleine-König
2016-07-10 10:07 ` [PATCH 5/6] ARM: dts: imx: fix polarity of fec reset gpios Uwe Kleine-König
2016-07-10 10:07 ` [PATCH 6/6] ARM: dts: imx6-wandboard: substitute NO_PAD_CTL by the respective reset value Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712073859.GQ16643@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).