[PATCH -next] spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove()

Andi Shyti
2016-07-13T04:50:30Z

Hi Wei,

> Once a spi_master_get() call succeeds, we need an additional
> spi_master_put() call to free the memory, otherwise we will
> leak a reference to master. Fix by removing the unnecessary
> spi_master_get() call.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

The patch doesn't have anything wrong, but what you write in the
description is not what you are doing in the patch.

There is no memory allocated in spi_master_get and nothing leaks.
Besides master's resources are managed, so that there would
not be any need to call spi_master_put().

spi_master_put() has been, indeed, removed in this commit:
91800f0e90050a4db4c77e940796f501e02af8be.

But even if you correct the commit log, I don't see much
advantage for this patch on its own.

Thanks,
Andi

> ---
> drivers/spi/spi-s3c64xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index df88fa1..001c9eb 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1211,7 +1211,7 @@ err0:
>
> static int s3c64xx_spi_remove(struct platform_device *pdev)
> {
> - struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
> + struct spi_master *master = platform_get_drvdata(pdev);
> struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master);
>
> pm_runtime_get_sync(&pdev->dev);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>