From: daniel@ffwll.ch (Daniel Vetter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all()
Date: Tue, 19 Jul 2016 10:05:18 +0200 [thread overview]
Message-ID: <20160719080518.GL17101@phenom.ffwll.local> (raw)
In-Reply-To: <CAOw6vbKAKnkYknXzCsvQCRqrha==MNNX_XdouDet_bdmW8gk-g@mail.gmail.com>
On Wed, Jul 13, 2016 at 11:23:29AM -0700, Sean Paul wrote:
> On Wed, Jul 13, 2016 at 9:39 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > drm_connector_unregister_all() is automatically called by
> > drm_dev_unregister() and so the manual call can be dropped.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Chen-Yu Tsai <wens@csie.org>
> > Cc: dri-devel at lists.freedesktop.org
> > Cc: linux-arm-kernel at lists.infradead.org
>
>
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
Done a backmerge and applied these two, thanks.
-Daniel
>
> > ---
> > drivers/gpu/drm/sun4i/sun4i_drv.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> > index 4dc543e1db10..7092daaf6c43 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> > @@ -185,7 +185,6 @@ static void sun4i_drv_unbind(struct device *dev)
> > {
> > struct drm_device *drm = dev_get_drvdata(dev);
> >
> > - drm_connector_unregister_all(drm);
> > drm_dev_unregister(drm);
> > drm_kms_helper_poll_fini(drm);
> > sun4i_framebuffer_free(drm);
> > --
> > 2.8.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-07-19 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 16:39 [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all() Chris Wilson
2016-07-13 17:56 ` Sean Paul
2016-07-13 18:05 ` Chris Wilson
2016-07-13 18:23 ` Sean Paul
2016-07-19 8:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719080518.GL17101@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).