[PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status

[PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status

[Ben Dooks]

The function pcibios_report_status() needs a declaration to avoid
the following warning, so declare it in <asm/pci.h>.

/home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-arm-kernel at lists.infradead.org
Cc: Russell King <linux@armlinux.org.uk>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/arm/include/asm/pci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h
index 057d381..4b5ea93 100644
--- a/arch/arm/include/asm/pci.h
+++ b/arch/arm/include/asm/pci.h
@@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
 	return channel ? 15 : 14;
 }
 
+extern void pcibios_report_status(unsigned int status_mask, int warn);
+
 #endif /* __KERNEL__ */
 #endif
-- 
2.8.1

[PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status

[Arnd Bergmann]

On Friday, June 17, 2016 4:05:05 PM CEST Ben Dooks wrote:
> The function pcibios_report_status() needs a declaration to avoid
> the following warning, so declare it in <asm/pci.h>.
> 
> /home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  arch/arm/include/asm/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h
> index 057d381..4b5ea93 100644
> --- a/arch/arm/include/asm/pci.h
> +++ b/arch/arm/include/asm/pci.h
> @@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
>  	return channel ? 15 : 14;
>  }
>  
> +extern void pcibios_report_status(unsigned int status_mask, int warn);
> +
>  #endif /* __KERNEL__ */
>  #endif
> 

Should we remove the declaration in arch/arm/mach-footbridge/dc21285.c
at the same time?

Another option would be to move the function to that file and make
it static, since nothing else uses it.

	Arnd

[PATCH 2/9] ARM: fix missing include of <asm/insn.h> in arch/arm/kernel/insn.c

[Ben Dooks]

Fix the warning by including <asm/insn.h> for the declaration
of __arm_gen_branch().

arm/kernel/insn.c:56:1: warning: symbol '__arm_gen_branch' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/kernel/insn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/kernel/insn.c b/arch/arm/kernel/insn.c
index b760340..5438934 100644
--- a/arch/arm/kernel/insn.c
+++ b/arch/arm/kernel/insn.c
@@ -1,6 +1,7 @@
 #include <linux/bug.h>
 #include <linux/kernel.h>
 #include <asm/opcodes.h>
+#include <asm/insn.h>
 
 static unsigned long
 __arm_gen_branch_thumb2(unsigned long pc, unsigned long addr, bool link)
-- 
2.8.1

[PATCH 3/9] ARM: add missing <asm/prom.h>

[Ben Dooks]

Fix the following warnings by including declarations
from <asm/prom.h>:

arch/arm/kernel/devtree.c:69:13: warning: symbol 'arm_dt_init_cpu_maps' was not declared. Should it be static?
arch/arm/kernel/devtree.c:210:27: warning: symbol 'setup_machine_fdt' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/kernel/devtree.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
index 2e26016..d42a9fe 100644
--- a/arch/arm/kernel/devtree.c
+++ b/arch/arm/kernel/devtree.c
@@ -23,6 +23,7 @@
 #include <asm/cputype.h>
 #include <asm/setup.h>
 #include <asm/page.h>
+#include <asm/prom.h>
 #include <asm/smp_plat.h>
 #include <asm/mach/arch.h>
 #include <asm/mach-types.h>
-- 
2.8.1

[PATCH 3/9] ARM: add missing <asm/prom.h>

[Arnd Bergmann]

On Friday, June 17, 2016 4:05:07 PM CEST Ben Dooks wrote:
> Fix the following warnings by including declarations
> from <asm/prom.h>:
> 
> arch/arm/kernel/devtree.c:69:13: warning: symbol 'arm_dt_init_cpu_maps' was not declared. Should it be static?
> arch/arm/kernel/devtree.c:210:27: warning: symbol 'setup_machine_fdt' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

[PATCH 4/9] ARM: fix missing <asm/vga.h> in arch/arm/mm/iomap.c

[Ben Dooks]

The vga_base is exported but has no declaration, so fix the
warning by including the declaration in <asm/vga.h>.

arch/arm/mm/iomap.c:12:15: warning: symbol 'vga_base' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/mm/iomap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mm/iomap.c b/arch/arm/mm/iomap.c
index 4614208..af177d6 100644
--- a/arch/arm/mm/iomap.c
+++ b/arch/arm/mm/iomap.c
@@ -9,6 +9,8 @@
 #include <linux/ioport.h>
 #include <linux/io.h>
 
+#include <asm/vga.h>
+
 unsigned long vga_base;
 EXPORT_SYMBOL(vga_base);
 
-- 
2.8.1

[PATCH 5/9] ARM: fix missing <linux/elf-randomize.h> in arch/arm/mm/mmap.c

[Ben Dooks]

The declaration of arch_mmap_rnd() is missing so fix it by
including <linux/elf-randomize.h>. Fixes:

/arch/arm/mm/mmap.c:172:15: warning: symbol 'arch_mmap_rnd' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-arm-kernel at lists.infradead.org
Cc: Russell King <linux@armlinux.org.uk>
---
 arch/arm/mm/mmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mm/mmap.c b/arch/arm/mm/mmap.c
index 66353ca..ac8de3a 100644
--- a/arch/arm/mm/mmap.c
+++ b/arch/arm/mm/mmap.c
@@ -9,6 +9,7 @@
 #include <linux/io.h>
 #include <linux/personality.h>
 #include <linux/random.h>
+#include <linux/elf-randomize.h>
 #include <asm/cachetype.h>
 
 #define COLOUR_ALIGN(addr,pgoff)		\
-- 
2.8.1

[PATCH 6/9] ARM: fix missing <asm/cacheflush.h> in arch/arm/mm/pageattr.c

[Ben Dooks]

Fix missing declarations in arch/arm/mm/pageattr.c by including
<asm/cacheflush.h>. Fixes:

arch/arm/mm/pageattr.c:71:5: warning: symbol 'set_memory_ro' was not declared. Should it be static?
arch/arm/mm/pageattr.c:78:5: warning: symbol 'set_memory_rw' was not declared. Should it be static?
arch/arm/mm/pageattr.c:85:5: warning: symbol 'set_memory_nx' was not declared. Should it be static?
arch/arm/mm/pageattr.c:92:5: warning: symbol 'set_memory_x' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/mm/pageattr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c
index d19b1ad..ef0612d 100644
--- a/arch/arm/mm/pageattr.c
+++ b/arch/arm/mm/pageattr.c
@@ -14,6 +14,7 @@
 #include <linux/module.h>
 
 #include <asm/pgtable.h>
+#include <asm/cacheflush.h>
 #include <asm/tlbflush.h>
 
 struct page_change_data {
-- 
2.8.1

[PATCH 7/9] ARM: probes: fix warning on NULL/0 substitution

[Ben Dooks]

Fix warning from use of '0' as NULL pointer.

arch/arm/probes/kprobes/actions-common.c:131:42: warning: Using plain integer as NULL pointer

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/probes/kprobes/actions-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/probes/kprobes/actions-common.c b/arch/arm/probes/kprobes/actions-common.c
index bd20a71..60bf926 100644
--- a/arch/arm/probes/kprobes/actions-common.c
+++ b/arch/arm/probes/kprobes/actions-common.c
@@ -128,7 +128,7 @@ enum probes_insn __kprobes
 kprobe_decode_ldmstm(probes_opcode_t insn, struct arch_probes_insn *asi,
 		const struct decode_header *h)
 {
-	probes_insn_handler_t *handler = 0;
+	probes_insn_handler_t *handler = NULL;
 	unsigned reglist = insn & 0xffff;
 	int is_ldm = insn & 0x100000;
 	int rn = (insn >> 16) & 0xf;
-- 
2.8.1

[PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy

[Ben Dooks]

At least on arm, <asm/dma.h> does not get included when building
drivers/pci/pci.o. This causes the following build warning which
can be fixed by including <asm/dma.h>:

drivers/pci/pci.c:37:5: warning: symbol 'isa_dma_bridge_buggy' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
---
 drivers/pci/pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 9add285..86b538d 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -26,6 +26,7 @@
 #include <linux/pm_runtime.h>
 #include <linux/pci_hotplug.h>
 #include <asm/setup.h>
+#include <asm/dma.h>
 #include <linux/aer.h>
 #include "pci.h"
 
-- 
2.8.1

[PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy

[Bjorn Helgaas]

On Fri, Jun 17, 2016 at 04:05:13PM +0100, Ben Dooks wrote:
> At least on arm, <asm/dma.h> does not get included when building
> drivers/pci/pci.o. This causes the following build warning which
> can be fixed by including <asm/dma.h>:
> 
> drivers/pci/pci.c:37:5: warning: symbol 'isa_dma_bridge_buggy' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied to pci/misc for v4.8, thanks, Ben!

> ---
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  drivers/pci/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 9add285..86b538d 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -26,6 +26,7 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/pci_hotplug.h>
>  #include <asm/setup.h>
> +#include <asm/dma.h>
>  #include <linux/aer.h>
>  #include "pci.h"
>  
> -- 
> 2.8.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html