linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1
Date: Thu, 21 Jul 2016 14:53:46 +0100	[thread overview]
Message-ID: <20160721145346.470fea00@arm.com> (raw)
In-Reply-To: <20160721134937.GA4603@potion>

On Thu, 21 Jul 2016 15:49:38 +0200
Radim Kr?m?? <rkrcmar@redhat.com> wrote:

> 2016-07-21 14:24+0100, Marc Zyngier:
> > On Thu, 21 Jul 2016 15:17:20 +0200
> > Radim Kr?m?? <rkrcmar@redhat.com> wrote:
> > 
> > Hi Radim,
> >   
> >> 2016-07-19 13:56+0100, Marc Zyngier:  
> >> > The kprobe enablement work has uncovered that changes made by
> >> > a guest to MDSCR_EL1 were propagated to the host when VHE was
> >> > enabled, leading to unexpected exception being delivered.
> >> > 
> >> > Moving this register to the list of registers that are always
> >> > context-switched fixes the issue.
> >> > 
> >> > Fixes: 9c6c35683286 ("arm64: KVM: VHE: Split save/restore of registers shared between guest and host")
> >> > Cc: stable at vger.kernel.org #4.6
> >> > Reported-by: Tirumalesh Chalamarla <Tirumalesh.Chalamarla@cavium.com>
> >> > Tested-by: Tirumalesh Chalamarla <Tirumalesh.Chalamarla@cavium.com>
> >> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >> > ---    
> >> 
> >> I would take this patch to 4.7 directly through the main tree.
> >> Are your plans different?  
> > 
> > If you're happy to take it now, that works for me.  
> 
> The fix is clear, tested, and would go to 4.7.stable.  Better to have it
> in 4.7, IMO.

Agreed.

> >                                                    I can either send a
> > PR right away, or you can apply it directly, whichever works best for
> > you.  
> 
> It is just one patch so I'll apply it and send a pull request to Linus
> on Saturday;  less cummulative work that way. :)

Brilliant. Thanks Radim.

	M.
-- 
Jazz is not dead. It just smells funny.

      reply	other threads:[~2016-07-21 13:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 12:56 [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1 Marc Zyngier
2016-07-21 13:17 ` Radim Krčmář
2016-07-21 13:24   ` Marc Zyngier
2016-07-21 13:49     ` Radim Krčmář
2016-07-21 13:53       ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721145346.470fea00@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).