linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: mm: make create_mapping_late() non-allocating
Date: Mon, 25 Jul 2016 15:22:42 +0100	[thread overview]
Message-ID: <20160725142241.GC14465@leverpostej> (raw)
In-Reply-To: <3728BEC2-B1C8-40A5-9E0C-E27D56149BD4@linaro.org>

On Mon, Jul 25, 2016 at 04:10:50PM +0200, Ard Biesheuvel wrote:
> > On 25 jul. 2016, at 15:46, Mark Rutland <mark.rutland@arm.com> wrote:
> > How about we drop the __init marker from create_mapping_noalloc(), and
> > update the callers in mark_rodata_ro() to use that, so that we can drop
> > create_mapping_late() entirely.
> > 
> > Other than the __init marker and name, create_mapping_late() and
> > create_mapping_noalloc() would be identical after this change, and the
> > naming of create_mapping_noalloc() does better describe what we're
> > trying to achieve in mark_rodata_ro().
> 
> Not entirely. The _late() variant should map down to pages if the
> first mapping was mapped down to pages as well. The _noalloc() variant
> may end attempting to merge regions

Ah, I was comparing against mainline rather than the arm64 for-next/core
branch with the recent rework. Sorry for the noise.

Given that, FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

  reply	other threads:[~2016-07-25 14:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22 17:32 [PATCH 0/2] arm64: mm: use fully constructed struct pages from EFI page tables Ard Biesheuvel
2016-07-22 17:32 ` [PATCH 1/2] arm64: mm: make create_mapping_late() non-allocating Ard Biesheuvel
2016-07-25 13:46   ` Mark Rutland
2016-07-25 14:10     ` Ard Biesheuvel
2016-07-25 14:22       ` Mark Rutland [this message]
2016-07-22 17:32 ` [PATCH 2/2] arm64: mm: run pgtable_page_ctor() on non-swapper translation table pages Ard Biesheuvel
2016-07-25 14:31   ` Suzuki K Poulose
2016-07-25 14:43     ` Suzuki K Poulose
2016-07-25 16:46       ` Catalin Marinas
2016-07-25 17:03         ` Suzuki K Poulose
2016-07-22 21:53 ` [PATCH 0/2] arm64: mm: use fully constructed struct pages from EFI page tables Laura Abbott
2016-07-25 13:48 ` Sudeep Holla
2016-07-25 17:14 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160725142241.GC14465@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).