From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Fix Kconfig dependencies for RANDOMIZE_BASE
Date: Tue, 26 Jul 2016 18:45:56 +0100 [thread overview]
Message-ID: <20160726174556.GH2423@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1469553415-26839-1-git-send-email-jeffv@google.com>
On Tue, Jul 26, 2016 at 10:16:55AM -0700, Jeff Vander Stoep wrote:
> Selecting CONFIG_RANDOMIZE_BASE=y and CONFIG_MODULES=n causes a
> build error due to dependencies on modules. This patch makes KASLR
> module config options dependent on CONFIG_MODULES=y.
>
> Signed-off-by: Jeff Vander Stoep <jeffv@google.com>
> ---
> arch/arm64/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7e23f95..c9eff79 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -891,7 +891,6 @@ config RELOCATABLE
>
> config RANDOMIZE_BASE
> bool "Randomize the address of the kernel image"
> - select ARM64_MODULE_PLTS
> select RELOCATABLE
> help
> Randomizes the virtual address at which the kernel image is
I thought we need the module PLTs once we randomize the kernel base,
independent of whether we randomize the modules base or not. Could we do
something like:
select ARM64_MODULE_PLTS if MODULES
Whichever way we fix this, we probably need:
Fixes: f80fb3a3d508 ("arm64: add support for kernel ASLR")
Cc: <stable@vger.kernel.org> # 4.6+
--
Catalin
next prev parent reply other threads:[~2016-07-26 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 17:16 [PATCH] arm64: Fix Kconfig dependencies for RANDOMIZE_BASE Jeff Vander Stoep
2016-07-26 17:45 ` Catalin Marinas [this message]
2016-07-26 17:52 ` Ard Biesheuvel
2016-07-26 18:45 ` Mark Rutland
2016-07-27 6:55 ` Catalin Marinas
2016-07-26 17:53 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726174556.GH2423@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox