[PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables

Maxime Ripard
2016-07-27T06:59:34Z

On Tue, Jul 26, 2016 at 07:43:06PM +0200, Jean-Francois Moine wrote:
> On Tue, 26 Jul 2016 15:04:26 +0800
> Chen-Yu Tsai <wens@csie.org> wrote:
>
> > Some clock muxes have holes, i.e. invalid or unconnected inputs,
> > between parent mux values.
> >
> > Add support for specifying a mux table to map clock parents to
> > mux values.
>
> Putting empty strings in the holes should work. No?
> Ex:
>
> static const char * const csi_mclk_parents[] =
> { "pll-video0", "pll-video1", "", "", "", "osc24M" };

Not really. The clock would be declared as orphan, while it's really
not.

Parenting functions would also not work as expected,
clk_hw_get_parent_by_index being the obvious example, in that case
returning the empty string for an invalid parent, while it should
really return NULL.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160727/99c10432/attachment.sig>