From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] remoteproc: core: Add function to append a new resource table entry
Date: Thu, 4 Aug 2016 10:21:50 +0100 [thread overview]
Message-ID: <20160804092153.23032-7-lee.jones@linaro.org> (raw)
In-Reply-To: <20160804092153.23032-1-lee.jones@linaro.org>
A new function now exists to pull in and amend and existing resource
table entry. But what if we wish to provide a new resource? This
function provides functionality to append a brand new resource entry
onto the resource table. All complexity related to shuffling parts
of the table around, providing new offsets and incriminating number
of entries in the resource table's top-level header is taken care of
here.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/remoteproc/remoteproc_core.c | 55 ++++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 3318ebd..111350e 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -980,6 +980,61 @@ static int rproc_update_resource_table_entry(struct rproc *rproc,
return !updated;
}
+static struct resource_table*
+rproc_add_resource_table_entry(struct rproc *rproc,
+ struct rproc_request_resource *request,
+ struct resource_table *old_table, int *tablesz)
+{
+ struct resource_table *table;
+ struct fw_rsc_hdr h;
+ void *new_rsc_loc;
+ void *fw_header_loc;
+ void *start_of_rscs;
+ int new_rsc_offset;
+ int size = *tablesz;
+ int i;
+
+ h.type = request->type;
+
+ new_rsc_offset = size;
+
+ /*
+ * Allocate another contiguous chunk of memory, large enough to
+ * contain the new, expanded resource table.
+ *
+ * The +4 is for the extra offset[] element in the top level header
+ */
+ size += sizeof(struct fw_rsc_hdr) + request->size + 4;
+ table = devm_kmemdup(&rproc->dev, old_table, size, GFP_KERNEL);
+ if (!table)
+ return ERR_PTR(-ENOMEM);
+
+ /* Shunt table by 4 Bytes to account for the extra offset[] element */
+ start_of_rscs = (void *)table + table->offset[0];
+ memmove(start_of_rscs + 4,
+ start_of_rscs, new_rsc_offset - table->offset[0]);
+ new_rsc_offset += 4;
+
+ /* Update existing resource entry's offsets */
+ for (i = 0; i < table->num; i++)
+ table->offset[i] += 4;
+
+ /* Update the top level 'resource table' header */
+ table->offset[table->num] = new_rsc_offset;
+ table->num++;
+
+ /* Copy new firmware header into table */
+ fw_header_loc = (void *)table + new_rsc_offset;
+ memcpy(fw_header_loc, &h, sizeof(h));
+
+ /* Copy new resource entry into table */
+ new_rsc_loc = (void *)fw_header_loc + sizeof(h);
+ memcpy(new_rsc_loc, request->resource, request->size);
+
+ *tablesz = size;
+ return table;
+}
+
/*
* take a firmware and boot a remote processor with it.
*/
--
2.9.0
next prev parent reply other threads:[~2016-08-04 9:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 9:21 [PATCH 0/9] remoteproc: Allow platform-specific drivers to request resources Lee Jones
2016-08-04 9:21 ` [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones
2016-08-09 17:28 ` Bjorn Andersson
2016-08-09 18:12 ` Lee Jones
2016-08-10 20:11 ` Suman Anna
2016-08-11 7:36 ` Lee Jones
2016-08-11 19:19 ` Bjorn Andersson
2016-08-11 20:09 ` Suman Anna
2016-08-04 9:21 ` [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Lee Jones
2016-08-09 17:32 ` Bjorn Andersson
2016-08-09 18:12 ` Lee Jones
2016-08-04 9:21 ` [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones
2016-08-09 17:36 ` Bjorn Andersson
2016-08-09 18:10 ` Lee Jones
2016-08-10 17:47 ` Bjorn Andersson
2016-08-04 9:21 ` [PATCH 4/9] remoteproc: core: New API to add new resources to the resource table Lee Jones
2016-08-04 14:00 ` Lee Jones
2016-08-08 13:41 ` loic pallardy
2016-08-09 12:48 ` Lee Jones
2016-08-04 9:21 ` [PATCH 5/9] remoteproc: core: Add function to amend an existing resource table entry Lee Jones
2016-08-04 9:21 ` Lee Jones [this message]
2016-08-11 7:51 ` [PATCH 6/9] remoteproc: core: Add function to append a new " loic pallardy
2016-08-11 20:20 ` Bjorn Andersson
2016-08-12 11:54 ` loic pallardy
2016-08-04 9:21 ` [PATCH 7/9] remoteproc: core: Add function to over-ride current resource table Lee Jones
2016-08-08 13:47 ` loic pallardy
2016-08-09 12:46 ` Lee Jones
2016-08-04 9:21 ` [PATCH 8/9] remoteproc: core: Skip resource table integrity checks if there are amendments Lee Jones
2016-08-09 17:40 ` Bjorn Andersson
2016-08-04 9:21 ` [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones
2016-08-05 7:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804092153.23032-7-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).