From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo
Date: Thu, 4 Aug 2016 17:57:48 -0700 [thread overview]
Message-ID: <20160805005748.GC15690@codeaurora.org> (raw)
In-Reply-To: <20160711223827.GA6053@hector.attlocal.net>
On 07/11, Andy Gross wrote:
> On Mon, Jul 11, 2016 at 02:50:08PM -0700, Stephen Boyd wrote:
> > The voltage ranges listed here are wrong. The pma8084 pldo
> > supports three different overlapping voltage ranges with
> > differing step sizes and the pma8084 ftsmps supports two. These
> > ranges can be seen in the "native" spmi regulator driver
> > (qcom_spmi-regulator.c) at pldo_ranges[] and ftsmps_ranges[]
> > respectively. Port these ranges over to the RPM SMD regulator
> > driver so that we list the appropriate set of supported voltages
> > on these types of regulators.
> >
> > Cc: Andy Gross <andy.gross@linaro.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Fixes: ee01d0c91ef1 ("regulator: qcom-smd: Add support for PMA8084")
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>
> <snip>
>
> > static const struct regulator_desc pma8084_pldo = {
> > .linear_ranges = (struct regulator_linear_range[]) {
> > - REGULATOR_LINEAR_RANGE(750000, 0, 30, 25000),
> > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
> > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500),
>
> It was my understanding that the PMOS ldos only support 25mV and 50mV
> incremements.
>
Unfortunately that isn't true. It also supports 12.5mV steps for
the lower voltage ranges.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-05 0:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 21:50 [PATCH 0/3] Fixes for RPM SMD regulator voltage ranges Stephen Boyd
2016-07-11 21:50 ` [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Stephen Boyd
2016-07-11 22:48 ` Andy Gross
2016-08-05 0:58 ` Stephen Boyd
2016-08-05 4:09 ` Andy Gross
2016-08-05 12:09 ` Applied "regulator: qcom_smd: Fix voltage ranges for pm8x41" to the regulator tree Mark Brown
2016-08-13 4:00 ` Bjorn Andersson
2016-08-15 12:51 ` Mark Brown
2016-07-11 21:50 ` [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo Stephen Boyd
2016-07-11 22:38 ` Andy Gross
2016-08-05 0:57 ` Stephen Boyd [this message]
2016-08-05 4:09 ` Andy Gross
2016-08-05 12:09 ` Applied "regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo" to the regulator tree Mark Brown
2016-07-11 21:50 ` [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear voltage ranges Stephen Boyd
2016-07-11 22:39 ` Andy Gross
2016-07-12 9:02 ` Applied "regulator: qcom_smd: Avoid overlapping linear voltage ranges" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805005748.GC15690@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).