From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 4/6] perf tools: pushing driver configuration down to the kernel
Date: Fri, 5 Aug 2016 12:32:46 +0200 [thread overview]
Message-ID: <20160805103246.GC12528@krava> (raw)
In-Reply-To: <1470329604-14356-5-git-send-email-mathieu.poirier@linaro.org>
On Thu, Aug 04, 2016 at 10:53:22AM -0600, Mathieu Poirier wrote:
SNIP
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 418ed94756d3..df74bdbb7524 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -940,6 +940,10 @@ static int callchain_param__setup_sample_type(struct callchain_param *callchain)
>
> static int __cmd_top(struct perf_top *top)
> {
> + char msg[512];
> + struct perf_evsel *pos;
> + struct perf_evsel_config_term *err_term;
> + struct perf_evlist *evlist = top->evlist;
> struct record_opts *opts = &top->record_opts;
> pthread_t thread;
> int ret;
> @@ -976,6 +980,13 @@ static int __cmd_top(struct perf_top *top)
> if (ret)
> goto out_delete;
>
> + if (perf_evlist__apply_drv_configs(evlist, &pos, &err_term)) {
> + error("failed to set config \"%s\" on event %s with %d (%s)\n",
> + err_term->val.drv_cfg, perf_evsel__name(pos), errno,
> + strerror_r(errno, msg, sizeof(msg)));
hum ret is 0 in here..
> + goto out_delete;
> + }
thanks,
jirka
next prev parent reply other threads:[~2016-08-05 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 16:53 [PATCH V4 0/6] perf: Driver specific configuration for PMU Mathieu Poirier
2016-08-04 16:53 ` [PATCH V4 1/6] perf/core: Adding PMU driver specific configuration Mathieu Poirier
2016-08-04 16:53 ` [PATCH V4 2/6] perf: Passing struct perf_event to function setup_aux() Mathieu Poirier
2016-08-04 16:53 ` [PATCH V4 3/6] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier
2016-08-04 16:53 ` [PATCH V4 4/6] perf tools: pushing driver configuration down to the kernel Mathieu Poirier
2016-08-05 10:32 ` Jiri Olsa [this message]
2016-08-04 16:53 ` [PATCH V4 5/6] coresight: adding sink parameter to function coresight_build_path() Mathieu Poirier
2016-08-04 16:53 ` [PATCH V4 6/6] coresight: etm-perf: incorporating sink definition from cmd line Mathieu Poirier
2016-08-05 9:32 ` Suzuki K Poulose
2016-08-05 15:44 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805103246.GC12528@krava \
--to=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).