From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: dts: imx53: add support for USB armory board
Date: Mon, 8 Aug 2016 15:08:03 +0800 [thread overview]
Message-ID: <20160808070803.GB4678@tiger> (raw)
In-Reply-To: <20160628125444.16531-3-andrej@inversepath.com>
One more comment below.
On Tue, Jun 28, 2016 at 02:54:44PM +0200, andrej at inversepath.com wrote:
> +&iomuxc {
> + pinctrl_esdhc1: esdhc1grp {
> + fsl,pins = <
> + MX53_PAD_SD1_DATA0__ESDHC1_DAT0 0x1d5
> + MX53_PAD_SD1_DATA1__ESDHC1_DAT1 0x1d5
> + MX53_PAD_SD1_DATA2__ESDHC1_DAT2 0x1d5
> + MX53_PAD_SD1_DATA3__ESDHC1_DAT3 0x1d5
> + MX53_PAD_SD1_CMD__ESDHC1_CMD 0x1d5
> + MX53_PAD_SD1_CLK__ESDHC1_CLK 0x1d5
> + >;
> + };
> +
> + pinctrl_i2c1_pmic: i2c1grp_pmic {
> + fsl,pins = <
> + MX53_PAD_EIM_D21__I2C1_SCL 0x0
> + MX53_PAD_EIM_D28__I2C1_SDA 0x0
Please use a proper pin configuration value rather than 0x0.
> + >;
> + };
> +
> + pinctrl_led: led {
> + fsl,pins = <
> + MX53_PAD_DISP0_DAT6__GPIO4_27 0x0
Ditto.
Shawn
> + >;
> + };
prev parent reply other threads:[~2016-08-08 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 12:54 [PATCH v2 0/2] imx53: add support for USB armory board andrej at inversepath.com
2016-06-28 12:54 ` [PATCH v2 1/2] devicetree: Add vendor prefix for Inverse Path andrej at inversepath.com
2016-06-28 21:10 ` Rob Herring
2016-06-28 12:54 ` [PATCH v2 2/2] ARM: dts: imx53: add support for USB armory board andrej at inversepath.com
2016-08-08 6:59 ` Shawn Guo
2016-08-08 7:08 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808070803.GB4678@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox