From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] remoteproc: core: Remove pointless OOM print
Date: Tue, 9 Aug 2016 10:36:53 -0700 [thread overview]
Message-ID: <20160809173653.GD26240@tuxbot> (raw)
In-Reply-To: <20160804092153.23032-4-lee.jones@linaro.org>
On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:
> These types of error prints are superfluous. The system will
> pick up on OOM issues and let the user know.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Although, I think we should drop the "mapping" object. We have all the
information in the carveout object to reverse the mapping at cleanup.
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 5654a81..4914482 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -619,7 +619,6 @@ static int rproc_handle_carveout(struct rproc *rproc,
> if (rproc->domain) {
> mapping = kzalloc(sizeof(*mapping), GFP_KERNEL);
> if (!mapping) {
> - dev_err(dev, "kzalloc mapping failed\n");
> ret = -ENOMEM;
> goto dma_free;
> }
> --
> 2.9.0
>
next prev parent reply other threads:[~2016-08-09 17:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 9:21 [PATCH 0/9] remoteproc: Allow platform-specific drivers to request resources Lee Jones
2016-08-04 9:21 ` [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones
2016-08-09 17:28 ` Bjorn Andersson
2016-08-09 18:12 ` Lee Jones
2016-08-10 20:11 ` Suman Anna
2016-08-11 7:36 ` Lee Jones
2016-08-11 19:19 ` Bjorn Andersson
2016-08-11 20:09 ` Suman Anna
2016-08-04 9:21 ` [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Lee Jones
2016-08-09 17:32 ` Bjorn Andersson
2016-08-09 18:12 ` Lee Jones
2016-08-04 9:21 ` [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones
2016-08-09 17:36 ` Bjorn Andersson [this message]
2016-08-09 18:10 ` Lee Jones
2016-08-10 17:47 ` Bjorn Andersson
2016-08-04 9:21 ` [PATCH 4/9] remoteproc: core: New API to add new resources to the resource table Lee Jones
2016-08-04 14:00 ` Lee Jones
2016-08-08 13:41 ` loic pallardy
2016-08-09 12:48 ` Lee Jones
2016-08-04 9:21 ` [PATCH 5/9] remoteproc: core: Add function to amend an existing resource table entry Lee Jones
2016-08-04 9:21 ` [PATCH 6/9] remoteproc: core: Add function to append a new " Lee Jones
2016-08-11 7:51 ` loic pallardy
2016-08-11 20:20 ` Bjorn Andersson
2016-08-12 11:54 ` loic pallardy
2016-08-04 9:21 ` [PATCH 7/9] remoteproc: core: Add function to over-ride current resource table Lee Jones
2016-08-08 13:47 ` loic pallardy
2016-08-09 12:46 ` Lee Jones
2016-08-04 9:21 ` [PATCH 8/9] remoteproc: core: Skip resource table integrity checks if there are amendments Lee Jones
2016-08-09 17:40 ` Bjorn Andersson
2016-08-04 9:21 ` [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones
2016-08-05 7:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809173653.GD26240@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).