* [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear
@ 2016-08-08 23:48 Shuah Khan
2016-08-09 18:27 ` Krzysztof Kozlowski
2016-08-10 17:37 ` Javier Martinez Canillas
0 siblings, 2 replies; 3+ messages in thread
From: Shuah Khan @ 2016-08-08 23:48 UTC (permalink / raw)
To: linux-arm-kernel
Fix unsupported GEM memory type error message to include the memory type
information.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
Changes since v1:
-- Comment changed to read clearly
drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
index e016640..40ce841 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
@@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev,
flags = exynos_gem->flags;
/*
- * without iommu support, not support physically non-continuous memory
- * for framebuffer.
+ * Physically non-contiguous memory type for framebuffer is not
+ * supported without IOMMU.
*/
if (IS_NONCONTIG_BUFFER(flags)) {
- DRM_ERROR("cannot use this gem memory type for fb.\n");
+ DRM_ERROR("Non-contiguous GEM memory is not supported.\n");
return -EINVAL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear
2016-08-08 23:48 [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear Shuah Khan
@ 2016-08-09 18:27 ` Krzysztof Kozlowski
2016-08-10 17:37 ` Javier Martinez Canillas
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-08-09 18:27 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 08, 2016 at 05:48:20PM -0600, Shuah Khan wrote:
> Fix unsupported GEM memory type error message to include the memory type
> information.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Changes since v1:
> -- Comment changed to read clearly
>
> drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Hi,
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear
2016-08-08 23:48 [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear Shuah Khan
2016-08-09 18:27 ` Krzysztof Kozlowski
@ 2016-08-10 17:37 ` Javier Martinez Canillas
1 sibling, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2016-08-10 17:37 UTC (permalink / raw)
To: linux-arm-kernel
Hello Shuah,
On 08/08/2016 07:48 PM, Shuah Khan wrote:
> Fix unsupported GEM memory type error message to include the memory type
> information.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Changes since v1:
> -- Comment changed to read clearly
>
> drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> index e016640..40ce841 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev,
> flags = exynos_gem->flags;
>
> /*
> - * without iommu support, not support physically non-continuous memory
> - * for framebuffer.
> + * Physically non-contiguous memory type for framebuffer is not
> + * supported without IOMMU.
> */
> if (IS_NONCONTIG_BUFFER(flags)) {
> - DRM_ERROR("cannot use this gem memory type for fb.\n");
> + DRM_ERROR("Non-contiguous GEM memory is not supported.\n");
> return -EINVAL;
> }
>
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-10 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-08 23:48 [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear Shuah Khan
2016-08-09 18:27 ` Krzysztof Kozlowski
2016-08-10 17:37 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).