From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: apply more __ro_after_init
Date: Wed, 10 Aug 2016 10:43:39 +0100 [thread overview]
Message-ID: <20160810094339.GK1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1464979224-2085-3-git-send-email-keescook@chromium.org>
On Fri, Jun 03, 2016 at 11:40:24AM -0700, Kees Cook wrote:
> @@ -1309,16 +1309,11 @@ void __init arm_mm_memblock_reserve(void)
> * Any other function or debugging method which may touch any device _will_
> * crash the kernel.
> */
> +static char vectors[PAGE_SIZE * 2] __ro_after_init __aligned(PAGE_SIZE);
> static void __init devicemaps_init(const struct machine_desc *mdesc)
> {
> struct map_desc map;
> unsigned long addr;
> - void *vectors;
> -
> - /*
> - * Allocate the vector page early.
> - */
> - vectors = early_alloc(PAGE_SIZE * 2);
This one is not appropriate. We _do_ write to these pages after init
for FIQ handler updates. See set_fiq_handler().
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-08-10 9:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 18:40 [PATCH 0/2] expand use of __ro_after_init Kees Cook
2016-06-03 18:40 ` [PATCH 1/2] x86: apply more __ro_after_init and const Kees Cook
2016-06-03 18:40 ` [PATCH 2/2] arm: apply more __ro_after_init Kees Cook
2016-06-03 18:51 ` [kernel-hardening] " Greg KH
2016-06-03 21:26 ` Kees Cook
2016-06-03 21:54 ` Greg KH
2016-06-03 22:01 ` Kees Cook
2016-08-10 9:43 ` Russell King - ARM Linux [this message]
2016-08-10 10:00 ` Arnd Bergmann
2016-08-10 10:12 ` Russell King - ARM Linux
2016-08-10 19:31 ` Arnd Bergmann
2016-08-10 23:02 ` Russell King - ARM Linux
2016-08-11 16:02 ` Arnd Bergmann
2016-08-12 11:34 ` Daniel Thompson
2016-08-10 17:06 ` [kernel-hardening] " Daniel Micay
2016-08-10 18:32 ` Kees Cook
2016-08-10 19:41 ` Arnd Bergmann
2016-08-10 21:40 ` Kees Cook
2016-08-10 23:06 ` Russell King - ARM Linux
2016-08-11 15:54 ` Arnd Bergmann
2016-08-11 22:16 ` Kees Cook
2016-08-12 16:24 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810094339.GK1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).