linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: VDSO: put read only/mostly objects into proper sections
Date: Wed, 10 Aug 2016 17:59:58 +0800	[thread overview]
Message-ID: <20160810175958.4dcfc5e3@xhacker> (raw)
In-Reply-To: <1470820187-1032-1-git-send-email-jszhang@marvell.com>

+ Kees

On Wed, 10 Aug 2016 17:09:47 +0800 wrote:

> vdso_data_mapping is never modified, so mark it as const.
> 
> vdso_data_page and vdso_text_mapping are initialized by vdso_init(),
> thereafter are mostly read during vdso special mapping handling.
> 
> The fact that they are mostly read and not written to makes them
> candidates for __read_mostly declarations.

Inspired by Kees's "arm: apply more __ro_after_init", is it better
to mark these vars as __ro_after_init?

Thanks,
Jisheng

> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  arch/arm/kernel/vdso.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index 994e971..c946092 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -47,13 +47,13 @@ unsigned int vdso_total_pages __read_mostly;
>  static union vdso_data_store vdso_data_store __page_aligned_data;
>  static struct vdso_data *vdso_data = &vdso_data_store.data;
>  
> -static struct page *vdso_data_page;
> -static struct vm_special_mapping vdso_data_mapping = {
> +static struct page *vdso_data_page __read_mostly;
> +static const struct vm_special_mapping vdso_data_mapping = {
>  	.name = "[vvar]",
>  	.pages = &vdso_data_page,
>  };
>  
> -static struct vm_special_mapping vdso_text_mapping = {
> +static struct vm_special_mapping vdso_text_mapping __read_mostly = {
>  	.name = "[vdso]",
>  };
>  

  reply	other threads:[~2016-08-10  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  9:09 [PATCH] ARM: VDSO: put read only/mostly objects into proper sections Jisheng Zhang
2016-08-10  9:59 ` Jisheng Zhang [this message]
2016-08-10 18:47   ` Kees Cook
2016-08-10 19:04     ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810175958.4dcfc5e3@xhacker \
    --to=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).