public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page
Date: Mon, 15 Aug 2016 10:17:54 +0100	[thread overview]
Message-ID: <20160815091754.GC1426@svinekod> (raw)
In-Reply-To: <1471243546-3090-3-git-send-email-jszhang@marvell.com>

On Mon, Aug 15, 2016 at 02:45:45PM +0800, Jisheng Zhang wrote:
> The vm_special_mapping spec which is used for aarch32 vectors page is
> never modified, so mark it as const.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>

I see that this is never deliberately modified before being passed to
_install_special_mapping, which takes it as a const pointer. So this looks good
to me:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/kernel/vdso.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> index e320e8f..10ad8ab 100644
> --- a/arch/arm64/kernel/vdso.c
> +++ b/arch/arm64/kernel/vdso.c
> @@ -88,7 +88,7 @@ int aarch32_setup_vectors_page(struct linux_binprm *bprm, int uses_interp)
>  {
>  	struct mm_struct *mm = current->mm;
>  	unsigned long addr = AARCH32_VECTORS_BASE;
> -	static struct vm_special_mapping spec = {
> +	static const struct vm_special_mapping spec = {
>  		.name	= "[vectors]",
>  		.pages	= vectors_page,
>  
> -- 
> 2.8.1
> 

  reply	other threads:[~2016-08-15  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15  6:45 [PATCH v4 0/3] arm64: put objects into proper sections Jisheng Zhang
2016-08-15  6:45 ` [PATCH v4 1/3] arm64: vdso: add __init section marker to alloc_vectors_page Jisheng Zhang
2016-08-15  9:13   ` Mark Rutland
2016-08-15  6:45 ` [PATCH v4 2/3] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page Jisheng Zhang
2016-08-15  9:17   ` Mark Rutland [this message]
2016-08-15  6:45 ` [PATCH v4 3/3] arm64: apply __ro_after_init to some objects Jisheng Zhang
2016-08-15  9:33   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815091754.GC1426@svinekod \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox