From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: Add missing newline terminators to kernel messages
Date: Tue, 16 Aug 2016 20:13:38 +0100 [thread overview]
Message-ID: <20160816191338.GL1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1471354832-18456-1-git-send-email-geert+renesas@glider.be>
On Tue, Aug 16, 2016 at 03:40:32PM +0200, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Before commit 874f9c7da9a4acbc ("printk: create pr_<level> functions"),
> pr_*() calls without a trailing newline characters would be printed with
> a newline character appended, both on the console and in the output of
> the dmesg command.
>
> After that commit, no new line character is appended, and the output of
> the next pr_*() call of the same type may be appended:
>
> - Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000
> - Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)
> + Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)
>
> and:
>
> -No ATAGs?
> -hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
> +No ATAGs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
>
> While this commit has been reverted in commit a0cba2179ea4c182 ("Revert
> "printk: create pr_<level> functions""), it's still good practice to
> terminate kernel messages with newlines.
Shouldn't that be above the "---" line?
Other than that, patch looks fine, thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-08-16 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 13:40 [PATCH v2] ARM: Add missing newline terminators to kernel messages Geert Uytterhoeven
2016-08-16 17:08 ` Joe Perches
2016-08-16 17:50 ` Geert Uytterhoeven
2016-08-16 18:01 ` Joe Perches
2016-08-16 18:06 ` Geert Uytterhoeven
2016-08-16 19:13 ` Russell King - ARM Linux [this message]
2016-08-16 20:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816191338.GL1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).