linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kbeldan@baylibre.com (Karl Beldan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card
Date: Wed, 17 Aug 2016 10:33:46 +0000	[thread overview]
Message-ID: <20160817103346.GB8009@gobelin> (raw)
In-Reply-To: <aeec6ee5-91e9-13fa-f7fa-09581ddb9b6a@ti.com>

On Wed, Aug 17, 2016 at 03:24:42PM +0530, Sekhar Nori wrote:
> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
> > The LCDK embeds a TLV320AIC3106 connected to the SoC McASP for analog
> > audio. This relies on the 'dummy' regulator as the codec is always on.
> > Quality is good with arecord -pipe- aplay on Line In/Line Out.
> > The MIC path doesn't seem to work yet.
> 
> I tested the patch and I could not get the MIC to work as well. I
> suggest dropping the MIC path parts till that is debugged and root caused.
> 

Ok.

> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> > ---
> >  arch/arm/boot/dts/da850-lcdk.dts | 75 ++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 75 insertions(+)
> 
> > +&i2c0 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&i2c0_pins>;
> > +	clock-frequency = <100000>;
> > +	status = "okay";
> > +
> > +	tlv320aic3106: tlv320aic3106 at 18 {
> > +		#sound-dai-cells = <0>;
> > +		compatible = "ti,tlv320aic3106";
> > +		reg = <0x18>;
> > +		status = "okay";
> > +
> > +		ai3x-micbias-vg = <MICBIAS_2_5V>;
> 
> It will be nice to add the codec regulators as well (and that in turn
> needs the PMIC to be populated). Although I wont insist on that since
> the regulators are optional properties.
> 

In the patch comment I stated it relied on the dummy regulator as the
codec is always on but maybe I should have been more precise: it is not
out of convenience to keep things on, it is by HW design: I mentioned
it in the comment of "ARM: dts: da850: Add basic DTS for the LCDK":
 "the main PMIC, different and hard-wired on the LCDK (the LDOs and
 DCDCs are always on)" after reviewing the schematics.
I could add that in the patch comment.

Thanks for reviewing.

Rgds, 
Karl

  reply	other threads:[~2016-08-17 10:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 20:08 [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card Karl Beldan
2016-08-10 20:08 ` [PATCH 2/2] ARM: davinci_all_defconfig: enable modules for sound on LCDK Karl Beldan
2016-08-17  8:50   ` Sekhar Nori
2016-08-17 10:13     ` Karl Beldan
2016-08-17 10:38       ` Sekhar Nori
2016-08-17 13:01         ` Karl Beldan
2016-08-17  6:49 ` [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card Sekhar Nori
2016-08-17  9:54 ` Sekhar Nori
2016-08-17 10:33   ` Karl Beldan [this message]
2016-08-17 11:32     ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160817103346.GB8009@gobelin \
    --to=kbeldan@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).