linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Fix Qualcomm 8064/8660 interrupt flags
Date: Wed, 17 Aug 2016 13:47:40 -0700	[thread overview]
Message-ID: <20160817204740.GQ26240@tuxbot> (raw)
In-Reply-To: <20160817194322.GB18215@hector.attlocal.net>

On Wed 17 Aug 12:43 PDT 2016, Andy Gross wrote:

> On Wed, Aug 17, 2016 at 10:56:22AM +0200, Linus Walleij wrote:
> > On Fri, Aug 5, 2016 at 10:38 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > 
> > > This came out after some frustration with trying to flag a PM8058
> > > interrupt line on the APQ8060 (MSM8660) to trigger on falling
> > > edges. It was conflicting badly with predefined contradictory
> > > flags in the device tree for the entire GPIO block. The same
> > > seems to hold for the MPP GPIO IRQs.
> > 
> > Andy are you funneling these two patches for fixes?
> 
> I looked at these last night.  What's the outcome of John's issues with the
> patch not fixing his problem?  Do these need to be taken irrespective of his
> plight?
> 

John's issue was that the order of operations was changed in the IRQ
framework, so that upon passing through the set_type() in the TLMM
driver I would overwrite, and hence disable, the chained IRQ handler -
as I should.

As the PMIC interrupt is chained from the TLMM no interrupts was
delivered.


So please move forward with these changes.

Regards,
Bjorn

  reply	other threads:[~2016-08-17 20:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05  8:38 [PATCH 0/2] Fix Qualcomm 8064/8660 interrupt flags Linus Walleij
2016-08-05  8:38 ` [PATCH 1/2] ARM: dts: MSM8064 remove flags from SPMI/MPP IRQs Linus Walleij
2016-08-05 17:56   ` John Stultz
2016-08-05  8:38 ` [PATCH 2/2] ARM: dts: MSM8660 " Linus Walleij
2016-08-17  8:56 ` [PATCH 0/2] Fix Qualcomm 8064/8660 interrupt flags Linus Walleij
2016-08-17 19:43   ` Andy Gross
2016-08-17 20:47     ` Bjorn Andersson [this message]
2016-08-17 21:12       ` Andy Gross
2016-08-18 13:12     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160817204740.GQ26240@tuxbot \
    --to=bjorn.andersson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).