From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn.andersson@linaro.org (Bjorn Andersson) Date: Thu, 18 Aug 2016 11:09:40 -0700 Subject: [PATCH 08/14] rpmsg: Split rpmsg core and virtio backend In-Reply-To: References: <1471306640-29917-1-git-send-email-bjorn.andersson@linaro.org> <1471306640-29917-9-git-send-email-bjorn.andersson@linaro.org> Message-ID: <20160818180940.GU26240@tuxbot> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu 18 Aug 04:59 PDT 2016, Loic PALLARDY wrote: > > > > -----Original Message----- > > From: linux-remoteproc-owner at vger.kernel.org [mailto:linux-remoteproc- > > owner at vger.kernel.org] On Behalf Of Bjorn Andersson > > Sent: Tuesday, August 16, 2016 2:17 AM > > To: Ohad Ben-Cohen ; Bjorn Andersson > > > > Cc: linux-remoteproc at vger.kernel.org; linux-arm-msm at vger.kernel.org; > > linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; > > Sricharan R > > Subject: [PATCH 08/14] rpmsg: Split rpmsg core and virtio backend > > > > Extract the generic rpmsg core functionality from the virtio rpmsg > > implementation, splitting the implementation in a rpmsg core and a > > virtio backend. > > > > Based on initial work by Sricharan R > > > > Cc: Sricharan R > > Signed-off-by: Bjorn Andersson > > --- > > drivers/rpmsg/Kconfig | 4 + > > drivers/rpmsg/Makefile | 3 +- > > drivers/rpmsg/rpmsg_core.c | 513 > > +++++++++++++++++++++++++++++++++++++++ > > drivers/rpmsg/rpmsg_internal.h | 45 ++++ > > drivers/rpmsg/virtio_rpmsg_bus.c | 477 +----------------------------------- > Hi Bjorn, > > Could you please regenerate the patch with option -M (of git > formatpatch) to detect file renames. It will provide better > visibility of differences between virtio_rpmsg_bus.c and rpmsg_core.c. I believe this is with -M, but as I only extracted part of the file it did not detect it as a rename. I will see if I can figure something out for v2. Perhaps if I split the move in more than one commit it will be easier to follow; like take the device management in one chunk and the rpmsg_send() functions in one would reduce the size of the two patches quite a bit. > > > 5 files changed, 569 insertions(+), 473 deletions(-) > > create mode 100644 drivers/rpmsg/rpmsg_core.c > > create mode 100644 drivers/rpmsg/rpmsg_internal.h > > > > diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig > > index 69a219387582..40614be88c97 100644 > > --- a/drivers/rpmsg/Kconfig > > +++ b/drivers/rpmsg/Kconfig > > @@ -3,6 +3,10 @@ menu "Rpmsg drivers" > > # RPMSG always gets selected by whoever wants it > > config RPMSG > > tristate > > + > > +config RPMSG_VIRTIO > > + tristate > > + select RPMSG > > select VIRTIO > > select VIRTUALIZATION > > > Remoteproc Kconfig should be changed too to select RPMSG_VIRTIO instead of RPMSG. > You're right, forgot to include that. I still think this should be a user selectable option, rather than being tied to particular remoteproc drivers - but let's take that discussion separately. Thanks, Bjorn