From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] Input: jornada720_kbd - switch to devm_* APIs
Date: Fri, 19 Aug 2016 10:00:30 -0700 [thread overview]
Message-ID: <20160819170030.GD20499@dtor-ws> (raw)
In-Reply-To: <20160819164547.GU1041@n2100.armlinux.org.uk>
On Fri, Aug 19, 2016 at 05:45:47PM +0100, Russell King - ARM Linux wrote:
> On Fri, Aug 19, 2016 at 09:44:47AM -0700, Dmitry Torokhov wrote:
> > On Fri, Aug 19, 2016 at 05:30:59PM +0100, Russell King wrote:
> > > Switch the jornada720_kbd driver to use the devm_* APIs. This is in
> > > preparation to removing the mach/irqs.h include from this driver.
> > >
> > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > ---
> > > drivers/input/keyboard/jornada720_kbd.c | 38 ++++++++-------------------------
> > > 1 file changed, 9 insertions(+), 29 deletions(-)
> > >
> > > diff --git a/drivers/input/keyboard/jornada720_kbd.c b/drivers/input/keyboard/jornada720_kbd.c
> > > index 421d9c55b0e8..4b2e9ff18ba1 100644
> > > --- a/drivers/input/keyboard/jornada720_kbd.c
> > > +++ b/drivers/input/keyboard/jornada720_kbd.c
> > > @@ -53,6 +53,7 @@ static unsigned short jornada_std_keymap[128] = { /* ROW */
> > > struct jornadakbd {
> > > unsigned short keymap[ARRAY_SIZE(jornada_std_keymap)];
> > > struct input_dev *input;
> > > + int irq;
> >
> > I do not think you need this, not in this patch and the next one does
> > not seem to need this either?
> >
> > Can I drop this chunk?
>
> Yes, that was accidentally left in while I was considering how to update
> the driver. It can be safely dropped. Thanks for spotting that.
Great. I'll also drop now empty jornada720_kbd_remove() and apply.
Thanks.
--
Dmitry
prev parent reply other threads:[~2016-08-19 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 16:30 [PATCH v2 1/2] Input: jornada720_kbd - switch to devm_* APIs Russell King
2016-08-19 16:44 ` Dmitry Torokhov
2016-08-19 16:45 ` Russell King - ARM Linux
2016-08-19 17:00 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819170030.GD20499@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).