From: mhocko@kernel.org (Michal Hocko)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page
Date: Mon, 22 Aug 2016 10:03:58 +0200 [thread overview]
Message-ID: <20160822080358.GF13596@dhcp22.suse.cz> (raw)
In-Reply-To: <1471834603-27053-3-git-send-email-xieyisheng1@huawei.com>
On Mon 22-08-16 10:56:43, Xie Yisheng wrote:
> Arm64 supports gigantic page after
> commit 084bd29810a5 ("ARM64: mm: HugeTLB support.")
> however, it got broken by
> commit 944d9fec8d7a ("hugetlb: add support for gigantic page
> allocation at runtime")
>
> This patch selects ARCH_HAS_GIGANTIC_PAGE to make this
> function can be used again.
I haven't double checked that the above commit really broke it but if
that is the case then
Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime")
would be nice as well I guess. I do not think that marking it for stable
is really necessary considering how long it's been broken and nobody has
noticed...
> Signed-off-by: Xie Yisheng <xieyisheng1@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index bc3f00f..92217f6 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -9,6 +9,7 @@ config ARM64
> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
> select ARCH_HAS_ELF_RANDOMIZE
> select ARCH_HAS_GCOV_PROFILE_ALL
> + select ARCH_HAS_GIGANTIC_PAGE
> select ARCH_HAS_KCOV
> select ARCH_HAS_SG_CHAIN
> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
> --
> 1.7.12.4
>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-08-22 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 2:56 [RFC PATCH v2 0/2] arm64/hugetlb: enable gigantic page Xie Yisheng
2016-08-22 2:56 ` [RFC PATCH v2 1/2] mm/hugetlb: Introduce ARCH_HAS_GIGANTIC_PAGE Xie Yisheng
2016-08-22 8:01 ` Michal Hocko
2016-08-22 10:37 ` Yisheng Xie
2016-08-22 2:56 ` [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Xie Yisheng
2016-08-22 8:03 ` Michal Hocko [this message]
2016-08-22 10:00 ` Catalin Marinas
2016-08-22 11:33 ` Yisheng Xie
2016-08-22 10:21 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822080358.GF13596@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).