linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RTF 7/7] arm64: dts: r8a7796: salvator-x: enable SDHI0 & 3
Date: Mon, 22 Aug 2016 11:25:56 +0200	[thread overview]
Message-ID: <20160822092555.GC7896@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVjmVobeTNSf9kWtWaGk6zcWRjGKkjKqfFmqx0ZJYJurg@mail.gmail.com>

On Wed, Aug 17, 2016 at 05:52:17PM +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 17, 2016 at 1:31 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Enable the exposed SD card slots in the DT of the r8a7796/salvator-x.
> >
> > Based on work for the r8a7795/salvator-x by Ai Kyuse.
> >
> > Cc: Ai Kyuse <ai.kyuse.uw@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 84 ++++++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> > index bb34b8d69c79..f06621f2ee4c 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> 
> > @@ -36,12 +86,46 @@
> >                 groups = "scif2_data_a";
> >                 function = "scif2";
> >         };
> > +
> > +       sdhi0_pins: sd0 {
> > +               groups = "sdhi0_data4", "sdhi0_ctrl";
> > +               function = "sdhi0";
> > +       };
> > +
> > +       sdhi3_pins: sd3 {
> > +               groups = "sdhi3_data4", "sdhi3_ctrl";
> > +               function = "sdhi3";
> > +       };
> >  };
> >
> >  &extal_clk {
> >         clock-frequency = <16666666>;
> >  };
> >
> > +&sdhi0 {
> > +       pinctrl-0 = <&sdhi0_pins>;
> > +       pinctrl-names = "default";
> > +
> > +       vmmc-supply = <&vcc_sdhi0>;
> > +       vqmmc-supply = <&vccq_sdhi0>;
> > +       cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
> > +       wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> 
> BTW, is there a specific reason CD and WP use GPIOs, and not the
> dedicated sdhi0_cd and sdhi0_wp pin config?
> It's done the same on r8a7795/salvator-x.

Good point. I'll try and follow up on that.

> > +       bus-width = <4>;
> > +       status = "okay";
> > +};
> > +
> > +&sdhi3 {
> > +       pinctrl-0 = <&sdhi3_pins>;
> > +       pinctrl-names = "default";
> > +
> > +       vmmc-supply = <&vcc_sdhi3>;
> > +       vqmmc-supply = <&vccq_sdhi3>;
> > +       cd-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
> > +       wp-gpios = <&gpio4 16 GPIO_ACTIVE_HIGH>;
> 
> Likewise.
> 
> > +       bus-width = <4>;
> > +       status = "okay";
> > +};
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

  reply	other threads:[~2016-08-22  9:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 11:31 [PATCH/RTF 0/7] Add SDHI to r8a7796/salvator-x Simon Horman
2016-08-17 11:31 ` [PATCH/RTF 1/7] clk: renesas: r8a7796: Add GPIO clocks Simon Horman
2016-08-17 13:40   ` Geert Uytterhoeven
2016-08-17 11:31 ` [PATCH/RTF 2/7] clk: renesas: r8a7796: Add SDIF clocks Simon Horman
2016-08-17 13:47   ` Geert Uytterhoeven
2016-08-22  9:15     ` Simon Horman
2016-08-17 11:31 ` [PATCH/RTF 3/7] pinctrl: sh-pfc: r8a7796: Add SDHI pins, groups and functions Simon Horman
2016-08-17 15:31   ` Geert Uytterhoeven
2016-08-17 11:31 ` [PATCH/RTF 4/7] mmc: sh_mobile_sdhi: Add r8a7796 support Simon Horman
2016-08-17 15:36   ` Geert Uytterhoeven
2016-08-17 11:31 ` [PATCH/RTF 5/7] arm64: dts: r8a7796: Add GPIO device nodes Simon Horman
2016-08-17 15:41   ` Geert Uytterhoeven
2016-08-22  9:15     ` Simon Horman
2016-08-17 11:31 ` [PATCH/RTF 6/7] arm64: dts: r8a7796: add SDHI nodes Simon Horman
2016-08-17 15:43   ` Geert Uytterhoeven
2016-08-17 11:31 ` [PATCH/RTF 7/7] arm64: dts: r8a7796: salvator-x: enable SDHI0 & 3 Simon Horman
2016-08-17 15:52   ` Geert Uytterhoeven
2016-08-22  9:25     ` Simon Horman [this message]
2016-08-25  3:31     ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160822092555.GC7896@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).