linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules
@ 2016-08-19 16:47 Karl Beldan
  2016-08-19 16:47 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Karl Beldan @ 2016-08-19 16:47 UTC (permalink / raw)
  To: linux-arm-kernel

This enables UBI+UBIFS to handle the NAND MTDs, including the useful
MTD_UBI_BLOCK.

Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
---
 arch/arm/configs/davinci_all_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
index cc94af9d..5e5dd6b 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -66,6 +66,8 @@ CONFIG_MTD_M25P80=m
 CONFIG_MTD_NAND=m
 CONFIG_MTD_NAND_DAVINCI=m
 CONFIG_MTD_SPI_NOR=m
+CONFIG_MTD_UBI=m
+CONFIG_MTD_UBI_BLOCK=y
 CONFIG_BLK_DEV_LOOP=m
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_COUNT=1
@@ -188,6 +190,7 @@ CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
 CONFIG_JFFS2_FS=m
+CONFIG_UBIFS_FS=m
 CONFIG_CRAMFS=y
 CONFIG_MINIX_FS=m
 CONFIG_NFS_FS=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
  2016-08-19 16:47 [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
@ 2016-08-19 16:47 ` Karl Beldan
  2016-08-23  9:13   ` Sekhar Nori
  2016-08-19 16:58 ` [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
  2016-08-23 10:53 ` Sekhar Nori
  2 siblings, 1 reply; 9+ messages in thread
From: Karl Beldan @ 2016-08-19 16:47 UTC (permalink / raw)
  To: linux-arm-kernel

The davinci boards don't have their clocks in DT yet and getting a clock
with a null con_id will fail, unless registering them as clk_lookups.
This registers the aemif clock for the ti-aemif memory driver.

The current aemif lookup entry resolving to the same clock:
    'CLK(NULL,               "aemif",        &aemif_clk)'
is currently used by davinci_nand and remains for non-DT and backward
compatibility.

Currently the davinci boards only configure the AEMIF in case of non-DT
boot, via some code in mach-davinci.
This change will allow DT-based davinci platforms to do the same, via
the ti-aemif memory driver code.

Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
---
 This patch was originally patch 1/4 of the series
 "Add DT support for NAND to LCDK via ti-aemif" from which two other
 patches have already applied in Sekhar's tree.
 Sekhar, please note that commit 31e3a881 ("ARM: dts: da850,da850-evm:
 Add an aemif node and use it for the NAND") of your tree depends on
 this change.

 Thanks, 
 Karl

v2:
 - Reword the commit message more accurately after Sekhar's feedback


 arch/arm/mach-davinci/da850.c    | 1 +
 arch/arm/mach-davinci/da8xx-dt.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
index 0d046ac..ed3d0e9 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
@@ -501,6 +501,7 @@ static struct clk_lookup da850_clks[] = {
 	CLK("da8xx_lcdc.0",	"fck",		&lcdc_clk),
 	CLK("da830-mmc.0",	NULL,		&mmcsd0_clk),
 	CLK("da830-mmc.1",	NULL,		&mmcsd1_clk),
+	CLK("ti-aemif",		NULL,		&aemif_clk),
 	CLK(NULL,		"aemif",	&aemif_clk),
 	CLK(NULL,		"usb11",	&usb11_clk),
 	CLK(NULL,		"usb20",	&usb20_clk),
diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
index ca99711..c9f7e92 100644
--- a/arch/arm/mach-davinci/da8xx-dt.c
+++ b/arch/arm/mach-davinci/da8xx-dt.c
@@ -37,6 +37,7 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = {
 	OF_DEV_AUXDATA("ti,davinci-dm6467-emac", 0x01e20000, "davinci_emac.1",
 		       NULL),
 	OF_DEV_AUXDATA("ti,da830-mcasp-audio", 0x01d00000, "davinci-mcasp.0", NULL),
+	OF_DEV_AUXDATA("ti,da850-aemif", 0x68000000, "ti-aemif", NULL),
 	{}
 };
 
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
  2016-08-19 16:48 Karl Beldan
@ 2016-08-19 16:48 ` Karl Beldan
  2016-08-19 16:55   ` Karl Beldan
  0 siblings, 1 reply; 9+ messages in thread
From: Karl Beldan @ 2016-08-19 16:48 UTC (permalink / raw)
  To: linux-arm-kernel

The davinci boards don't have their clocks in DT yet and getting a clock
with a null con_id will fail, unless registering them as clk_lookups.
This registers the aemif clock for the ti-aemif memory driver.

The current aemif lookup entry resolving to the same clock:
    'CLK(NULL,               "aemif",        &aemif_clk)'
is currently used by davinci_nand and remains for non-DT and backward
compatibility.

Currently the davinci boards only configure the AEMIF in case of non-DT
boot, via some code in mach-davinci.
This change will allow DT-based davinci platforms to do the same, via
the ti-aemif memory driver code.

Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
---
 This patch was originally patch 1/4 of the series
 "Add DT support for NAND to LCDK via ti-aemif" from which two other
 patches have already applied in Sekhar's tree.
 Sekhar, please note that commit 31e3a881 ("ARM: dts: da850,da850-evm:
 Add an aemif node and use it for the NAND") of your tree depends on
 this change.

 Thanks, 
 Karl

v2:
 - Reword the commit message more accurately after Sekhar's feedback


 arch/arm/mach-davinci/da850.c    | 1 +
 arch/arm/mach-davinci/da8xx-dt.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
index 0d046ac..ed3d0e9 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
@@ -501,6 +501,7 @@ static struct clk_lookup da850_clks[] = {
 	CLK("da8xx_lcdc.0",	"fck",		&lcdc_clk),
 	CLK("da830-mmc.0",	NULL,		&mmcsd0_clk),
 	CLK("da830-mmc.1",	NULL,		&mmcsd1_clk),
+	CLK("ti-aemif",		NULL,		&aemif_clk),
 	CLK(NULL,		"aemif",	&aemif_clk),
 	CLK(NULL,		"usb11",	&usb11_clk),
 	CLK(NULL,		"usb20",	&usb20_clk),
diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
index ca99711..c9f7e92 100644
--- a/arch/arm/mach-davinci/da8xx-dt.c
+++ b/arch/arm/mach-davinci/da8xx-dt.c
@@ -37,6 +37,7 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = {
 	OF_DEV_AUXDATA("ti,davinci-dm6467-emac", 0x01e20000, "davinci_emac.1",
 		       NULL),
 	OF_DEV_AUXDATA("ti,da830-mcasp-audio", 0x01d00000, "davinci-mcasp.0", NULL),
+	OF_DEV_AUXDATA("ti,da850-aemif", 0x68000000, "ti-aemif", NULL),
 	{}
 };
 
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
  2016-08-19 16:48 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
@ 2016-08-19 16:55   ` Karl Beldan
  0 siblings, 0 replies; 9+ messages in thread
From: Karl Beldan @ 2016-08-19 16:55 UTC (permalink / raw)
  To: linux-arm-kernel

I sent this email twice, let's discard this one.

Thanks, 
Karl

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules
  2016-08-19 16:47 [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
  2016-08-19 16:47 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
@ 2016-08-19 16:58 ` Karl Beldan
  2016-08-23 10:53 ` Sekhar Nori
  2 siblings, 0 replies; 9+ messages in thread
From: Karl Beldan @ 2016-08-19 16:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Aug 19, 2016 at 04:47:35PM +0000, Karl Beldan wrote:
> This enables UBI+UBIFS to handle the NAND MTDs, including the useful
> MTD_UBI_BLOCK.
> 
> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> ---
>  arch/arm/configs/davinci_all_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 

I wanted to send this one after 
"[PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock
matching" but wildcards failed me. I didn't include it in a series as
said commit is already a dependency of already applied changes.

Rgds, 
Karl

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
  2016-08-19 16:47 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
@ 2016-08-23  9:13   ` Sekhar Nori
  2016-08-23  9:52     ` Karl Beldan
  0 siblings, 1 reply; 9+ messages in thread
From: Sekhar Nori @ 2016-08-23  9:13 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 19 August 2016 10:17 PM, Karl Beldan wrote:
> The davinci boards don't have their clocks in DT yet and getting a clock
> with a null con_id will fail, unless registering them as clk_lookups.

This statement is true, but I am not sure why you limit it to those
clocks with null con_id. On DaVinci, all clocks need to be registered
via a clk_lookup entry. Else clk_get() will fail.

So can I just edit this to:

"
The davinci boards don't have their clocks in DT yet and getting a clock
will fail, unless registering them as clk_lookups.
"

while applying?

> This registers the aemif clock for the ti-aemif memory driver.
> 
> The current aemif lookup entry resolving to the same clock:
>     'CLK(NULL,               "aemif",        &aemif_clk)'
> is currently used by davinci_nand and remains for non-DT and backward
> compatibility.
> 
> Currently the davinci boards only configure the AEMIF in case of non-DT
> boot, via some code in mach-davinci.
> This change will allow DT-based davinci platforms to do the same, via
> the ti-aemif memory driver code.
> 
> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> ---
>  This patch was originally patch 1/4 of the series
>  "Add DT support for NAND to LCDK via ti-aemif" from which two other
>  patches have already applied in Sekhar's tree.
>  Sekhar, please note that commit 31e3a881 ("ARM: dts: da850,da850-evm:
>  Add an aemif node and use it for the NAND") of your tree depends on
>  this change.

yes, noted. While sending the pull request to ARM-SoC, I send the SoC
changes first.

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
  2016-08-23  9:13   ` Sekhar Nori
@ 2016-08-23  9:52     ` Karl Beldan
  2016-08-23 11:06       ` Sekhar Nori
  0 siblings, 1 reply; 9+ messages in thread
From: Karl Beldan @ 2016-08-23  9:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Aug 23, 2016 at 02:43:36PM +0530, Sekhar Nori wrote:
> On Friday 19 August 2016 10:17 PM, Karl Beldan wrote:
> > The davinci boards don't have their clocks in DT yet and getting a clock
> > with a null con_id will fail, unless registering them as clk_lookups.
> 
> This statement is true, but I am not sure why you limit it to those
> clocks with null con_id. On DaVinci, all clocks need to be registered
> via a clk_lookup entry. Else clk_get() will fail.
> 
> So can I just edit this to:
> 
> "
> The davinci boards don't have their clocks in DT yet and getting a clock
> will fail, unless registering them as clk_lookups.
> "
> 
> while applying?
> 

Sure, as well as a 'reworded commit message' tag.

Thanks, 
Karl

> > This registers the aemif clock for the ti-aemif memory driver.
> > 
> > The current aemif lookup entry resolving to the same clock:
> >     'CLK(NULL,               "aemif",        &aemif_clk)'
> > is currently used by davinci_nand and remains for non-DT and backward
> > compatibility.
> > 
> > Currently the davinci boards only configure the AEMIF in case of non-DT
> > boot, via some code in mach-davinci.
> > This change will allow DT-based davinci platforms to do the same, via
> > the ti-aemif memory driver code.
> > 
> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> > ---
> >  This patch was originally patch 1/4 of the series
> >  "Add DT support for NAND to LCDK via ti-aemif" from which two other
> >  patches have already applied in Sekhar's tree.
> >  Sekhar, please note that commit 31e3a881 ("ARM: dts: da850,da850-evm:
> >  Add an aemif node and use it for the NAND") of your tree depends on
> >  this change.
> 
> yes, noted. While sending the pull request to ARM-SoC, I send the SoC
> changes first.
> 
> Thanks,
> Sekhar

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules
  2016-08-19 16:47 [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
  2016-08-19 16:47 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
  2016-08-19 16:58 ` [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
@ 2016-08-23 10:53 ` Sekhar Nori
  2 siblings, 0 replies; 9+ messages in thread
From: Sekhar Nori @ 2016-08-23 10:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 19 August 2016 10:17 PM, Karl Beldan wrote:
> This enables UBI+UBIFS to handle the NAND MTDs, including the useful
> MTD_UBI_BLOCK.
> 
> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>

Applied to v4.9/defconfig

Regards,
Sekhar

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
  2016-08-23  9:52     ` Karl Beldan
@ 2016-08-23 11:06       ` Sekhar Nori
  0 siblings, 0 replies; 9+ messages in thread
From: Sekhar Nori @ 2016-08-23 11:06 UTC (permalink / raw)
  To: linux-arm-kernel

On Tuesday 23 August 2016 03:22 PM, Karl Beldan wrote:
> On Tue, Aug 23, 2016 at 02:43:36PM +0530, Sekhar Nori wrote:
>> On Friday 19 August 2016 10:17 PM, Karl Beldan wrote:
>>> The davinci boards don't have their clocks in DT yet and getting a clock
>>> with a null con_id will fail, unless registering them as clk_lookups.
>>
>> This statement is true, but I am not sure why you limit it to those
>> clocks with null con_id. On DaVinci, all clocks need to be registered
>> via a clk_lookup entry. Else clk_get() will fail.
>>
>> So can I just edit this to:
>>
>> "
>> The davinci boards don't have their clocks in DT yet and getting a clock
>> will fail, unless registering them as clk_lookups.
>> "
>>
>> while applying?
>>
> 
> Sure, as well as a 'reworded commit message' tag.

Applied to v4.9/soc

Author:     Karl Beldan <kbeldan@baylibre.com>
AuthorDate: Fri Aug 19 16:47:36 2016 +0000
Commit:     Sekhar Nori <nsekhar@ti.com>
CommitDate: Tue Aug 23 16:32:31 2016 +0530

    ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
    
    The davinci boards don't have their clocks in DT yet and getting a clock
    will fail, unless registering them as clk_lookups. This registers the
    aemif clock for the ti-aemif memory driver.
    
    The current aemif lookup entry resolving to the same clock:
        'CLK(NULL,               "aemif",        &aemif_clk)'
    is currently used by davinci_nand and remains for non-DT and backward
    compatibility.
    
    Currently the davinci boards only configure the AEMIF in case of non-DT
    boot, via some code in mach-davinci.
    This change will allow DT-based davinci platforms to do the same, via
    the ti-aemif memory driver code.
    
    Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
    [nsekhar at ti.com: reworded commit message]
    Signed-off-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-08-23 11:06 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-19 16:47 [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
2016-08-19 16:47 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
2016-08-23  9:13   ` Sekhar Nori
2016-08-23  9:52     ` Karl Beldan
2016-08-23 11:06       ` Sekhar Nori
2016-08-19 16:58 ` [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
2016-08-23 10:53 ` Sekhar Nori
  -- strict thread matches above, loose matches on Subject: below --
2016-08-19 16:48 Karl Beldan
2016-08-19 16:48 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
2016-08-19 16:55   ` Karl Beldan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).