linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results
Date: Tue, 23 Aug 2016 11:38:41 +0100	[thread overview]
Message-ID: <20160823103841.GD8724@red-moon> (raw)
In-Reply-To: <20160823003831.GN6502@codeaurora.org>

On Mon, Aug 22, 2016 at 05:38:31PM -0700, Stephen Boyd wrote:

[...]

> This all comes about because the firmware generates a session id
> for the SMC call and jams it in x6. The assembly on the
> non-secure side is written with a tight loop around the smc
> instruction so that when the return value indicates
> "interrupted", x6 is kept intact and the non-secure OS can jump
> back to the secure OS without register reloading. Perhaps
> referring to x6 as result value is not correct because it's
> really a session id that's irrelevant once the smc call
> completes.

Sorry I missed this bit. The session id is _generated_ by secure
firmware (probably only when the value passed in x6 == 0 (?))
and actually returned to the caller so that subsequent (interrupted)
calls can re-issue the same value, is that correct ?

If that's the case the value in x6 is a result value from an SMCCC
perspective and your current FW is not SMCCC compliant.

Lorenzo

  parent reply	other threads:[~2016-08-23 10:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20  5:51 [PATCH 0/2] Qualcomm SMCCC Session ID Support Andy Gross
2016-08-20  5:51 ` [PATCH 1/2] arm64: kernel: Add SMC Session ID to results Andy Gross
2016-08-22 13:43   ` Will Deacon
2016-08-22 14:02     ` Andy Gross
2016-08-22 14:53       ` Will Deacon
2016-08-22 15:16         ` Andy Gross
2016-08-23 12:39           ` Andy Gross
2016-08-23  0:38         ` Stephen Boyd
2016-08-23  9:07           ` Lorenzo Pieralisi
2016-08-23 10:38           ` Lorenzo Pieralisi [this message]
2016-08-23 12:36             ` Andy Gross
2016-08-30 20:16             ` Andy Gross
2016-08-31 14:36               ` Will Deacon
2016-08-24 18:24   ` Bjorn Andersson
2016-08-20  5:51 ` [PATCH 2/2] firmware: qcom: scm: Fix interrupted SCM calls Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823103841.GD8724@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).