From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
Date: Tue, 23 Aug 2016 17:16:19 +0200 [thread overview]
Message-ID: <20160823151619.GK20029@lunn.ch> (raw)
In-Reply-To: <1471964765-32708-1-git-send-email-weiyj.lk@gmail.com>
On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
Hi Wei
No need for the additional From:
git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.
Thanks
Andrew
> Fixes the following sparse warning:
>
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
> symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
> return 0;
> }
>
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> {
> struct device *dev = &mdiodev->dev;
> struct device_node *np = dev->of_node, *phy_node;
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-23 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 15:06 [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning Wei Yongjun
2016-08-23 15:16 ` Andrew Lunn [this message]
2016-08-23 15:41 ` Wei Yongjun
2016-08-23 15:50 ` Andrew Lunn
2016-08-23 16:40 ` Kedari Appana
2016-08-24 0:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823151619.GK20029@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox